netdev - Re: [TEST] kunit/cfg80211-ie-generation flaking ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f46c4a25fbfbc4ae6d8352426a6316a50bfa103.camel@sipsolutions.net>
Date: Thu, 13 Feb 2025 20:03:04 +0100
From: Johannes Berg <johannes@...solutions.net>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "Berg, Benjamin" <benjamin.berg@...el.com>, "netdev@...r.kernel.org"
	 <netdev@...r.kernel.org>
Subject: Re: [TEST] kunit/cfg80211-ie-generation flaking ?

On Thu, 2025-02-13 at 10:46 -0800, Jakub Kicinski wrote:
> On Thu, 13 Feb 2025 19:22:04 +0100 Johannes Berg wrote:
> > > We hit 3 failures in the last 3 days.  
> > 
> > Four, actually, it seems? ;-)
> 
> Yup! I jinxed it, it failed again after I sent the report :)

:)

It's weird that it happens in this test, or are others similar?

> > https://netdev-3.bots.linux.dev/kunit/results/987921/kunit-test.log
> > 
> > is your serial console simply too slow?
> > 
> > ok 70 cfg80211-inform-bss
> >     KTAP version 1
> >     # Subtest: cfg80211-ie-generation
> >     # module: cfg80211_tests
> >     1..2
> >         KTAP version 1
> >         # Subtest: test_gen_new_ie
> >         oaction: accept multicast without MFP
> > 
> > should say
> > 
> > "ok 4 public action: accept ..."
> > 
> > instead, I think?
> 
> Oh, that's annoying :( Thanks for investigating.
> I think the CI runs when the machine is overloaded by builds.
> I'll add some safety for that.

It almost feels like it shouldn't matter - couldn't qemu just kind of
'pause' the VM when the serial port isn't keeping up? I think you're
using qemu? But I guess I could also see why that might not be something
you want in other use cases...

Not sure, but it really seems more related to the output (buffering)
than anything else.

Are you using the tools/testing/kunit/kunit.py script?

johannes