netdev - Re: [PATCH net-next v2] net: Add options as a flexible array to struct ip_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250212175525.4e658590@kernel.org>
Date: Wed, 12 Feb 2025 17:55:25 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Gal Pressman <gal@...dia.com>
Cc: Alexander Lobakin <aleksander.lobakin@...el.com>,
 netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Andrew Lunn
 <andrew+netdev@...n.ch>, Tariq Toukan <tariqt@...dia.com>, Louis Peens
 <louis.peens@...igine.com>, Simon Horman <horms@...nel.org>, David Ahern
 <dsahern@...nel.org>, Pravin B Shelar <pshelar@....org>, Yotam Gigi
 <yotam.gi@...il.com>, Jamal Hadi Salim <jhs@...atatu.com>, Cong Wang
 <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>, Kees Cook
 <kees@...nel.org>, "Gustavo A. R. Silva" <gustavoars@...nel.org>,
 dev@...nvswitch.org, linux-hardening@...r.kernel.org, Ilya Maximets
 <i.maximets@....org>, Cosmin Ratiu <cratiu@...dia.com>
Subject: Re: [PATCH net-next v2] net: Add options as a flexible array to
 struct ip_tunnel_info

On Wed, 12 Feb 2025 20:13:28 +0200 Gal Pressman wrote:
> > You could leave this macro inplace and just change `(info) + 1` to
> > `(info)->options` avoiding changes in lots of files and adding casts
> > everywhere.  

+1

> I'd rather not, having a macro to do 'info->options' doesn't help code
> readability IMHO.

It'd avoid having to explicitly cast the types everywhere, too.