netdev - Re: [PATCH net-next v6 1/4] net: wangxun: Add support for PTP clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250212181744.606e5193@kernel.org>
Date: Wed, 12 Feb 2025 18:17:44 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Jiawen Wu <jiawenwu@...stnetic.com>
Cc: <andrew+netdev@...n.ch>, <davem@...emloft.net>, <edumazet@...gle.com>,
 <pabeni@...hat.com>, <richardcochran@...il.com>, <linux@...linux.org.uk>,
 <horms@...nel.org>, <jacob.e.keller@...el.com>, <netdev@...r.kernel.org>,
 <vadim.fedorenko@...ux.dev>, <mengyuanlou@...-swift.com>
Subject: Re: [PATCH net-next v6 1/4] net: wangxun: Add support for PTP clock

On Wed, 12 Feb 2025 15:45:52 +0800 Jiawen Wu wrote:
> > Why not use the aux_work for this?
> > IIUC aux_work often has lower latency since it's a dedicated thread.  
> 
> I think this task for checking TX timestamp is immediate and continuous
> after the skbuff is sent, and can be stopped after polling a valid timestamp.
> But aux_work for detecting overflow and error cases is a periodic task that
> is always carried out. It looks a little bit clearer if they were separated, but
> I could also try to merge it into aux_work if I need to.

Give it a go, I think it will work better when machine is heavily
loaded and workqueues get blasted with other work items. But not
a hard requirement if it's difficult to get right.