netdev - Re: [PATCH net-next 2/2] inet: consolidate inet_csk_clone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250213032604.83141-1-kuniyu@amazon.com>
Date: Thu, 13 Feb 2025 12:26:03 +0900
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <edumazet@...gle.com>
CC: <davem@...emloft.net>, <eric.dumazet@...il.com>, <horms@...nel.org>,
	<kuba@...nel.org>, <kuniyu@...zon.com>, <ncardwell@...gle.com>,
	<netdev@...r.kernel.org>, <pabeni@...hat.com>
Subject: Re: [PATCH net-next 2/2] inet: consolidate inet_csk_clone_lock()

From: Eric Dumazet <edumazet@...gle.com>
Date: Wed, 12 Feb 2025 13:13:28 +0000
> Current inet_sock_set_state trace from inet_csk_clone_lock() is missing
> many details :
> 
> ... sock:inet_sock_set_state: family=AF_INET6 protocol=IPPROTO_TCP \
>     sport=4901 dport=0 \
>     saddr=127.0.0.6 daddr=0.0.0.0 \
>     saddrv6=:: daddrv6=:: \
>     oldstate=TCP_LISTEN newstate=TCP_SYN_RECV
> 
> Only the sport gives the listener port, no other parts of the n-tuple are correct.
> 
> In this patch, I initialize relevant fields of the new socket before
> calling inet_sk_set_state(newsk, TCP_SYN_RECV).
> 
> We now have a trace including all the source/destination bits.
> 
> ... sock:inet_sock_set_state: family=AF_INET6 protocol=IPPROTO_TCP \
>     sport=4901 dport=47648 \
>     saddr=127.0.0.6 daddr=127.0.0.6 \
>     saddrv6=2002:a05:6830:1f85:: daddrv6=2001:4860:f803:65::3 \
>     oldstate=TCP_LISTEN newstate=TCP_SYN_RECV
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>