netdev - Re: [PATCH net V2] net: stmmac: dwmac-loongson: Set correct {tx,rx}_fifo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250212200606.0638ed60@kernel.org>
Date: Wed, 12 Feb 2025 20:06:06 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Huacai Chen <chenhuacai@...ngson.cn>
Cc: Huacai Chen <chenhuacai@...nel.org>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S . Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Yanteng Si
 <si.yanteng@...ux.dev>, Feiyang Chen <chris.chenfeiyang@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose Abreu
 <joabreu@...opsys.com>, Serge Semin <fancer.lancer@...il.com>,
 loongarch@...ts.linux.dev, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, stable@...r.kernel.org, Simon Horman
 <horms@...nel.org>, Chong Qiao <qiaochong@...ngson.cn>
Subject: Re: [PATCH net V2] net: stmmac: dwmac-loongson: Set correct
 {tx,rx}_fifo_size

On Mon, 10 Feb 2025 21:43:28 +0800 Huacai Chen wrote:
> Now for dwmac-loongson {tx,rx}_fifo_size are uninitialised, which means
> zero. This means dwmac-loongson doesn't support changing MTU because in
> stmmac_change_mtu() it requires the fifo size be no less than MTU. Thus,
> set the correct tx_fifo_size and rx_fifo_size for it (16KB multiplied by
> queue counts).

Not all drivers support changing MTU. Supporting jumbo frames 
is a feature, so this commit enables the use of a feature. 
As such it is not a fix. I'm applying this to net-next.