netdev - Re: [PATCH net-next 3/3] selftests: drv-net: add a simple TSO test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250212201814.168bd1fb@kernel.org>
Date: Wed, 12 Feb 2025 20:18:14 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Stanislav Fomichev <stfomichev@...il.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
 willemb@...gle.com, shuah@...nel.org, petrm@...dia.com
Subject: Re: [PATCH net-next 3/3] selftests: drv-net: add a simple TSO test

On Wed, 12 Feb 2025 18:49:38 -0800 Stanislav Fomichev wrote:
> > +            if cfg.have_stat_super_count:
> > +                ksft_lt(qstat_new['tx-hw-gso-packets'] -
> > +                        qstat_old['tx-hw-gso-packets'],
> > +                        100, comment="Number of LSO super-packets with LSO disabled")
> > +            if cfg.have_stat_wire_count:
> > +                ksft_lt(qstat_new['tx-hw-gso-wire-packets'] -
> > +                        qstat_old['tx-hw-gso-wire-packets'],
> > +                        1000, comment="Number of LSO wire-packets with LSO disabled")  
> 
> Why do you expect there to be some noise (100/1000) with the feature
> disabled?

We disable flag by flag. We may be disabling tunnel lso while some
background daemon is sending stuff with normal lso.

Looking at those numbers now, tho, I think I went a bit high.
100 * 64k = 6MB. We should probably set the noise to 10 super, 500 wire.
-- 
pw-bot: cr