netdev - Re: [PATCH v6 1/2] dt-bindings: net: Add FSD EQoS device tree bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <904930a2-61e7-4dba-8752-deff45cfeb2e@kernel.org>
Date: Fri, 14 Feb 2025 11:55:49 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Swathi K S <swathi.ks@...sung.com>
Cc: krzk+dt@...nel.org, andrew+netdev@...n.ch, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, robh@...nel.org,
 conor+dt@...nel.org, richardcochran@...il.com, mcoquelin.stm32@...il.com,
 alexandre.torgue@...s.st.com, rmk+kernel@...linux.org.uk,
 netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 'Pankaj Dubey' <pankaj.dubey@...sung.com>
Subject: Re: [PATCH v6 1/2] dt-bindings: net: Add FSD EQoS device tree
 bindings

On 14/02/2025 10:33, Swathi K S wrote:
>>> Could you please help in detail what specifically needs to be modified
>> regarding the ordering and minItems/maxItems usage?
>> You did not try hard enough.
>>
>> Open other bindings and look how they list clocks. For example any Samsung
>> clock controller bindings. Or any qcom bindings.
> 
> Thanks for your insight. I tried understanding the dt-binding implementations from Samsung/ qcom as you suggested.
> I am thinking of making the following modification in clock-names:
> 
> clock-names:
>      minItems: 5
>      items:
>          - const: ptp_ref
>          - const: master_bus
>          - const: slave_bus
>          - const: tx
>          - const: rx
>          - const: master2_bus
>          - const: slave2_bus
>          - const: eqos_rxclk_mux
>          - const: eqos_phyrxclk
>          - const: dout_peric_rgmii_clk
> 		 
> Does this align with your feedback or do you suggest any further changes?

Yes.

Best regards,
Krzysztof