netdev - Re: [PATCH net-next 3/4] net: phy: stop exporting phy_queue_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94e05493-4f34-4a34-b96a-63bb69aa3b9d@intel.com>
Date: Fri, 14 Feb 2025 12:00:44 +0100
From: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
To: Heiner Kallweit <hkallweit1@...il.com>, Andrew Lunn <andrew@...n.ch>,
	Russell King - ARM Linux <linux@...linux.org.uk>, Paolo Abeni
	<pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>, David Miller
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 3/4] net: phy: stop exporting
 phy_queue_state_machine



On 2/13/2025 10:50 PM, Heiner Kallweit wrote:
> phy_queue_state_machine() isn't used outside phy.c,
> so stop exporting it.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---
>   drivers/net/phy/phy.c | 4 ++--
>   include/linux/phy.h   | 1 -
>   2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> index d0c1718e2..8738ffb4c 100644
> --- a/drivers/net/phy/phy.c
> +++ b/drivers/net/phy/phy.c
> @@ -520,12 +520,12 @@ int __phy_hwtstamp_set(struct phy_device *phydev,
>    * @phydev: the phy_device struct
>    * @jiffies: Run the state machine after these jiffies
>    */
> -void phy_queue_state_machine(struct phy_device *phydev, unsigned long jiffies)
> +static void phy_queue_state_machine(struct phy_device *phydev,
> +				    unsigned long jiffies)
>   {
>   	mod_delayed_work(system_power_efficient_wq, &phydev->state_queue,
>   			 jiffies);
>   }
> -EXPORT_SYMBOL(phy_queue_state_machine);
>   
>   /**
>    * phy_trigger_machine - Trigger the state machine to run now
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index 33e2c2c93..bb7454364 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -2061,7 +2061,6 @@ int phy_drivers_register(struct phy_driver *new_driver, int n,
>   			 struct module *owner);
>   void phy_error(struct phy_device *phydev);
>   void phy_state_machine(struct work_struct *work);
> -void phy_queue_state_machine(struct phy_device *phydev, unsigned long jiffies);
>   void phy_trigger_machine(struct phy_device *phydev);
>   void phy_mac_interrupt(struct phy_device *phydev);
>   void phy_start_machine(struct phy_device *phydev);

Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@...el.com>