netdev - Re: [PATCH net-next 3/3] net: phy: mediatek: add driver for built-in 2.5G ethernet PHY on MT7988

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e58dabed4915e5c2dcece5f047e045ca08f836b6.camel@mediatek.com>
Date: Fri, 14 Feb 2025 13:23:17 +0000
From: SkyLake Huang (黃啟澤)
	<SkyLake.Huang@...iatek.com>
To: "andrew@...n.ch" <andrew@...n.ch>, "dqfext@...il.com" <dqfext@...il.com>,
	"davem@...emloft.net" <davem@...emloft.net>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, "linux@...linux.org.uk"
	<linux@...linux.org.uk>, "hkallweit1@...il.com" <hkallweit1@...il.com>,
	"daniel@...rotopia.org" <daniel@...rotopia.org>, "horms@...nel.org"
	<horms@...nel.org>, "kuba@...nel.org" <kuba@...nel.org>, "krzk@...nel.org"
	<krzk@...nel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "matthias.bgg@...il.com" <matthias.bgg@...il.com>
CC: Steven Liu (劉人豪) <steven.liu@...iatek.com>
Subject: Re: [PATCH net-next 3/3] net: phy: mediatek: add driver for built-in
 2.5G ethernet PHY on MT7988

On Thu, 2025-01-16 at 13:45 +0100, Krzysztof Kozlowski wrote:
> 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 16/01/2025 02:21, Sky Huang wrote:
> > +
> > +static int mt798x_2p5ge_phy_load_fw(struct phy_device *phydev)
> > +{
> > +     struct mtk_i2p5ge_phy_priv *priv = phydev->priv;
> > +     void __iomem *mcu_csr_base, *pmb_addr;
> > +     struct device *dev = &phydev->mdio.dev;
> > +     const struct firmware *fw;
> > +     struct device_node *np;
> > +     int ret, i;
> > +     u32 reg;
> > +
> > +     if (priv->fw_loaded)
> > +             return 0;
> > +
> > +     np = of_find_compatible_node(NULL, NULL, "mediatek,2p5gphy-
> > fw");
> 
> There is no such compatible. You cannot just add undocumented
> bindings.
> 
> Also, devices should not just look for some random compatibles.
> Express
> proper relationships with phandles or node hierarchy.
> 
Hi Krzysztof,
  OK. I'll add dt-bindings' document in next version.

BR,
Sky
>