netdev - Re: [PATCH net-next v4 14/16] net: airoha: Introduce flowtable offload support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202502142131.na71FjkW-lkp@intel.com>
Date: Fri, 14 Feb 2025 22:06:02 +0800
From: kernel test robot <lkp@...el.com>
To: Lorenzo Bianconi <lorenzo@...nel.org>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Felix Fietkau <nbd@....name>, Sean Wang <sean.wang@...iatek.com>,
	Matthias Brugger <matthias.bgg@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	"Chester A. Unal" <chester.a.unal@...nc9.com>,
	Daniel Golle <daniel@...rotopia.org>,
	DENG Qingfang <dqfext@...il.com>,
	Vladimir Oltean <olteanv@...il.com>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org, devicetree@...r.kernel.org,
	upstream@...oha.com
Subject: Re: [PATCH net-next v4 14/16] net: airoha: Introduce flowtable
 offload support

Hi Lorenzo,

kernel test robot noticed the following build warnings:

[auto build test WARNING on c3a97ccaed80986fc3c0581661bf9170847d23ba]

url:    https://github.com/intel-lab-lkp/linux/commits/Lorenzo-Bianconi/net-airoha-Fix-TSO-support-for-header-cloned-skbs/20250213-234737
base:   c3a97ccaed80986fc3c0581661bf9170847d23ba
patch link:    https://lore.kernel.org/r/20250213-airoha-en7581-flowtable-offload-v4-14-b69ca16d74db%40kernel.org
patch subject: [PATCH net-next v4 14/16] net: airoha: Introduce flowtable offload support
config: hexagon-allyesconfig (https://download.01.org/0day-ci/archive/20250214/202502142131.na71FjkW-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250214/202502142131.na71FjkW-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502142131.na71FjkW-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/airoha/airoha_ppe.c:818:6: warning: variable 'err' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
     818 |         if (!eth->npu)
         |             ^~~~~~~~~
   drivers/net/ethernet/airoha/airoha_ppe.c:820:7: note: uninitialized use occurs here
     820 |         if (!err)
         |              ^~~
   drivers/net/ethernet/airoha/airoha_ppe.c:818:2: note: remove the 'if' if its condition is always true
     818 |         if (!eth->npu)
         |         ^~~~~~~~~~~~~~
     819 |                 err = airoha_ppe_offload_setup(eth);
   drivers/net/ethernet/airoha/airoha_ppe.c:811:9: note: initialize the variable 'err' to silence this warning
     811 |         int err;
         |                ^
         |                 = 0
   1 warning generated.


vim +818 drivers/net/ethernet/airoha/airoha_ppe.c

   803	
   804	int airoha_ppe_setup_tc_block_cb(enum tc_setup_type type, void *type_data,
   805					 void *cb_priv)
   806	{
   807		struct flow_cls_offload *cls = type_data;
   808		struct net_device *dev = cb_priv;
   809		struct airoha_gdm_port *port = netdev_priv(dev);
   810		struct airoha_eth *eth = port->qdma->eth;
   811		int err;
   812	
   813		if (!tc_can_offload(dev) || type != TC_SETUP_CLSFLOWER)
   814			return -EOPNOTSUPP;
   815	
   816		mutex_lock(&flow_offload_mutex);
   817	
 > 818		if (!eth->npu)
   819			err = airoha_ppe_offload_setup(eth);
   820		if (!err)
   821			err = airoha_ppe_flow_offload_cmd(port, cls);
   822	
   823		mutex_unlock(&flow_offload_mutex);
   824	
   825		return err;
   826	}
   827	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki