netdev - Re: [net-next PATCH v9 3/6] octeontx2-af: CN20k mbox to support AF REQ/ACK functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202502142256.5RFZmK7u-lkp@intel.com>
Date: Fri, 14 Feb 2025 22:45:06 +0800
From: kernel test robot <lkp@...el.com>
To: Sai Krishna <saikrishnag@...vell.com>, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	sgoutham@...vell.com, gakula@...vell.com, lcherian@...vell.com,
	jerinj@...vell.com, hkelam@...vell.com, sbhatta@...vell.com,
	andrew+netdev@...n.ch, kalesh-anakkur.purayil@...adcom.com
Cc: oe-kbuild-all@...ts.linux.dev, Sai Krishna <saikrishnag@...vell.com>
Subject: Re: [net-next PATCH v9 3/6] octeontx2-af: CN20k mbox to support AF
 REQ/ACK functionality

Hi Sai,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Sai-Krishna/octeontx2-Set-appropriate-PF-VF-masks-and-shifts-based-on-silicon/20250214-013817
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250213170504.3892412-4-saikrishnag%40marvell.com
patch subject: [net-next PATCH v9 3/6] octeontx2-af: CN20k mbox to support AF REQ/ACK functionality
config: alpha-randconfig-r051-20250214 (https://download.01.org/0day-ci/archive/20250214/202502142256.5RFZmK7u-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250214/202502142256.5RFZmK7u-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502142256.5RFZmK7u-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/net/ethernet/marvell/octeontx2/af/rvu.c: In function 'rvu_free_hw_resources':
>> drivers/net/ethernet/marvell/octeontx2/af/rvu.c:760:25: error: 'RVU_AFPF' undeclared (first use in this function)
     760 |         pfvf = &rvu->pf[RVU_AFPF];
         |                         ^~~~~~~~
   drivers/net/ethernet/marvell/octeontx2/af/rvu.c:760:25: note: each undeclared identifier is reported only once for each function it appears in
   drivers/net/ethernet/marvell/octeontx2/af/rvu.c: In function 'rvu_probe':
   drivers/net/ethernet/marvell/octeontx2/af/rvu.c:3494:47: error: 'RVU_AFPF' undeclared (first use in this function)
    3494 |         rvu_alloc_cint_qint_mem(rvu, &rvu->pf[RVU_AFPF], BLKADDR_NIX0,
         |                                               ^~~~~~~~


vim +/RVU_AFPF +760 drivers/net/ethernet/marvell/octeontx2/af/rvu.c

   717	
   718	static void rvu_free_hw_resources(struct rvu *rvu)
   719	{
   720		struct rvu_hwinfo *hw = rvu->hw;
   721		struct rvu_block *block;
   722		struct rvu_pfvf  *pfvf;
   723		int id, max_msix;
   724		u64 cfg;
   725	
   726		rvu_npa_freemem(rvu);
   727		rvu_npc_freemem(rvu);
   728		rvu_nix_freemem(rvu);
   729	
   730		/* Free block LF bitmaps */
   731		for (id = 0; id < BLK_COUNT; id++) {
   732			block = &hw->block[id];
   733			kfree(block->lf.bmap);
   734		}
   735	
   736		/* Free MSIX bitmaps */
   737		for (id = 0; id < hw->total_pfs; id++) {
   738			pfvf = &rvu->pf[id];
   739			kfree(pfvf->msix.bmap);
   740		}
   741	
   742		for (id = 0; id < hw->total_vfs; id++) {
   743			pfvf = &rvu->hwvf[id];
   744			kfree(pfvf->msix.bmap);
   745		}
   746	
   747		/* Unmap MSIX vector base IOVA mapping */
   748		if (!rvu->msix_base_iova)
   749			return;
   750		cfg = rvu_read64(rvu, BLKADDR_RVUM, RVU_PRIV_CONST);
   751		max_msix = cfg & 0xFFFFF;
   752		dma_unmap_resource(rvu->dev, rvu->msix_base_iova,
   753				   max_msix * PCI_MSIX_ENTRY_SIZE,
   754				   DMA_BIDIRECTIONAL, 0);
   755	
   756		rvu_reset_msix(rvu);
   757		mutex_destroy(&rvu->rsrc_lock);
   758	
   759		/* Free the QINT/CINt memory */
 > 760		pfvf = &rvu->pf[RVU_AFPF];
   761		qmem_free(rvu->dev, pfvf->nix_qints_ctx);
   762		qmem_free(rvu->dev, pfvf->cq_ints_ctx);
   763	}
   764	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki