netdev - Re: [PATCH net-next 1/4] net: phy: remove fixup-related definitions from phy.h which are not used outside phylib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1be1ef1f-9f8f-4e91-9ec2-1ad19914bb93@lunn.ch>
Date: Fri, 14 Feb 2025 16:49:21 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: Mateusz Polchlopek <mateusz.polchlopek@...el.com>,
	Russell King - ARM Linux <linux@...linux.org.uk>,
	Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
	David Miller <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 1/4] net: phy: remove fixup-related definitions
 from phy.h which are not used outside phylib

On Fri, Feb 14, 2025 at 12:11:09PM +0100, Heiner Kallweit wrote:
> On 14.02.2025 11:59, Mateusz Polchlopek wrote:
> > 
> > 
> > On 2/13/2025 10:48 PM, Heiner Kallweit wrote:
> >> Certain fixup-related definitions aren't used outside phy_device.c.
> >> So make them private and remove them from phy.h.
> >>
> >> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> >> ---
> >>   drivers/net/phy/phy_device.c | 16 +++++++++++++---
> >>   include/linux/phy.h          | 14 --------------
> >>   2 files changed, 13 insertions(+), 17 deletions(-)
> >>
> >> diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
> >> index 9b06ba92f..14c312ad2 100644
> >> --- a/drivers/net/phy/phy_device.c
> >> +++ b/drivers/net/phy/phy_device.c
> >> @@ -45,6 +45,17 @@ MODULE_DESCRIPTION("PHY library");
> >>   MODULE_AUTHOR("Andy Fleming");
> >>   MODULE_LICENSE("GPL");
> >>   +#define    PHY_ANY_ID    "MATCH ANY PHY"
> >> +#define    PHY_ANY_UID    0xffffffff
> >> +
> > 
> > Overall looks like a nice cleanup but I am not sure about this space
> > between #define and PHY_ANY_ID or PHY_ANY_UID...
> > 
> There's a tab, which effectively equals a space. Maybe it's just the
> diff which is misleading. At least checkpatch didn't complain.

So long as it is a straight cut/paste from the old location, this is
fine.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew