[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAG-FcCOK36rYrf10iMp-B+j97skuwF4tTDOjJup2Sg=OA_HRNg@mail.gmail.com>
Date: Fri, 14 Feb 2025 13:31:13 -0800
From: Ziwei Xiao <ziweixiao@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Jeroen de Borst <jeroendb@...gle.com>, netdev@...r.kernel.org, davem@...emloft.net,
edumazet@...gle.com, pabeni@...hat.com, andrew+netdev@...n.ch,
willemb@...gle.com, horms@...nel.org,
Harshitha Ramamurthy <hramamurthy@...gle.com>, Praveen Kaligineedi <pkaligineedi@...gle.com>
Subject: Re: [PATCH net-next v3] gve: Add RSS cache for non RSS device option scenario
On Fri, Feb 14, 2025 at 6:38 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Thu, 13 Feb 2025 15:38:28 -0800 Jeroen de Borst wrote:
> > - return gve_adminq_configure_rss(priv, rxfh);
> > + err = gve_adminq_configure_rss(priv, rxfh);
> > + if (err) {
> > + NL_SET_ERR_MSG_MOD(extack, "Fail to configure RSS config\n");
>
> coccicheck says:
>
> drivers/net/ethernet/google/gve/gve_ethtool.c:915:29-61: WARNING avoid newline at end of message in NL_SET_ERR_MSG_MOD
Thanks for pointing this out. Will send a v4 patch to remove the `\n`.
> --
> pw-bot: cr
Powered by blists - more mailing lists