netdev - Re: [PATCH net-next v2] netdev: clarify GSO vs csum in qstats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67afce96ccece_312c64294fa@willemb.c.googlers.com.notmuch>
Date: Fri, 14 Feb 2025 18:15:34 -0500
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, 
 davem@...emloft.net
Cc: netdev@...r.kernel.org, 
 edumazet@...gle.com, 
 pabeni@...hat.com, 
 andrew+netdev@...n.ch, 
 horms@...nel.org, 
 Jakub Kicinski <kuba@...nel.org>, 
 willemb@...gle.com, 
 ecree.xilinx@...il.com, 
 neescoba@...co.com
Subject: Re: [PATCH net-next v2] netdev: clarify GSO vs csum in qstats

Jakub Kicinski wrote:
> Could be just me, but I had to pause and double check that the Tx csum
> counter in qstat should include GSO'd packets. GSO pretty much implies
> csum

Unfortunately specifically to virtio_net, this sensible limitation was
not enforced from the start. Which is why virtio_net_hdr_to_skb has a
branch for !VIRTIO_NET_HDR_F_NEEDS_CSUM && gso_type. Mainly "used" by
syzkaller afaik.

With the addition of USO besides TSO that could also eschew L4 checksum
offload. But the local stack does not generate those (udp_send_skb),
nor does UDP GRO (first branch in udp_gro_receive_segment).

In any case, the new comment clearly mentions this limitation on L4
checksum.

> so one could possibly interpret the csum counter as pure csum offload.
> 
> But the counters are based on virtio:
> 
>   [tx_needs_csum]
>       The number of packets which require checksum calculation by the device.
> 
>   [rx_needs_csum]
>       The number of packets with VIRTIO_NET_HDR_F_NEEDS_CSUM.
> 
> and VIRTIO_NET_HDR_F_NEEDS_CSUM gets set on GSO packets virtio sends.
> 
> Clarify this in the spec to avoid any confusion.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>

> ---
> v2:
>  - remove the note that almost all GSO types need L4 csum
> v1: https://lore.kernel.org/20250213010457.1351376-1-kuba@kernel.org
> 
> CC: willemb@...gle.com
> CC: ecree.xilinx@...il.com
> CC: neescoba@...co.com
> ---
>  Documentation/netlink/specs/netdev.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/netlink/specs/netdev.yaml b/Documentation/netlink/specs/netdev.yaml
> index 288923e965ae..48159eb116a4 100644
> --- a/Documentation/netlink/specs/netdev.yaml
> +++ b/Documentation/netlink/specs/netdev.yaml
> @@ -457,6 +457,8 @@ name: netdev
>          name: tx-needs-csum
>          doc: |
>            Number of packets that required the device to calculate the checksum.
> +          This counter includes the number of GSO wire packets for which device
> +          calculated the L4 checksum.
>          type: uint
>        -
>          name: tx-hw-gso-packets
> -- 
> 2.48.1
>