netdev - Re: [Intel-wired-lan] [iwl-next v9 5/9] ice, irdma: move interrupts code to irdma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z67XjwByeVSuLooq@mev-dev.igk.intel.com>
Date: Fri, 14 Feb 2025 06:41:35 +0100
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: Marcin Szycik <marcin.szycik@...ux.intel.com>
Cc: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
	intel-wired-lan@...ts.osuosl.org, himasekharx.reddy.pucha@...el.com,
	pmenzel@...gen.mpg.de, marcin.szycik@...el.com,
	netdev@...r.kernel.org, rafal.romanowski@...el.com,
	konrad.knitter@...el.com, pawel.chmielewski@...el.com,
	horms@...nel.org, David.Laight@...lab.com,
	nex.sw.ncis.nat.hpm.dev@...el.com, pio.raczynski@...il.com,
	sridhar.samudrala@...el.com, jacob.e.keller@...el.com,
	jiri@...nulli.us, przemyslaw.kitszel@...el.com,
	Tony Nguyen <anthony.l.nguyen@...el.com>
Subject: Re: [Intel-wired-lan] [iwl-next v9 5/9] ice, irdma: move interrupts
 code to irdma

On Thu, Feb 13, 2025 at 08:20:31PM +0100, Marcin Szycik wrote:
> 
> 
> On 03.12.2024 07:58, Michal Swiatkowski wrote:
> > Move responsibility of MSI-X requesting for RDMA feature from ice driver
> > to irdma driver. It is done to allow simple fallback when there is not
> > enough MSI-X available.
> > 
> > Change amount of MSI-X used for control from 4 to 1, as it isn't needed
> > to have more than one MSI-X for this purpose.
> 
> Hi, I'm observing KASAN reports or kernel panic when attempting to remove irdma
> with this patchset, most probably this patch being the culprit, since it touches
> functions from splat.
> 
> Reproducer:
>   sudo rmmod irdma
> 
> Minified splat(s):
>   BUG: KASAN: use-after-free in irdma_remove+0x257/0x2d0 [irdma]
>   Call Trace:
>    <TASK>
>    ? __pfx__raw_spin_lock_irqsave+0x10/0x10
>    ? kfree+0x253/0x450
>    ? irdma_remove+0x257/0x2d0 [irdma]
>    kasan_report+0xed/0x120
>    ? irdma_remove+0x257/0x2d0 [irdma]
>    irdma_remove+0x257/0x2d0 [irdma]
>    auxiliary_bus_remove+0x56/0x80
>    device_release_driver_internal+0x371/0x530
>    ? kernfs_put.part.0+0x147/0x310
>    driver_detach+0xbf/0x180
>    bus_remove_driver+0x11b/0x2a0
>    auxiliary_driver_unregister+0x1a/0x50
>    irdma_exit_module+0x40/0x4c [irdma]
>   
>   Oops: general protection fault, probably for non-canonical address 0xdffffc0000000000: 0000 [#1] PREEMPT SMP KASAN NOPTI
>   KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007]
>   RIP: 0010:ice_free_rdma_qvector+0x2a/0xa0 [ice]
>   Call Trace:
>    ? ice_free_rdma_qvector+0x2a/0xa0 [ice]
>    irdma_remove+0x179/0x2d0 [irdma]
>    auxiliary_bus_remove+0x56/0x80
>    device_release_driver_internal+0x371/0x530
>    ? kobject_put+0x61/0x4b0
>    driver_detach+0xbf/0x180
>    bus_remove_driver+0x11b/0x2a0
>    auxiliary_driver_unregister+0x1a/0x50
>    irdma_exit_module+0x40/0x4c [irdma]

Thanks, I will work on it.

>