netdev - Re: [PATCH bpf-next v11 09/12] bpf: add BPF_SOCK_OPS_TS_ACK_OPT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67b0afb7b65d1_36e344294cf@willemb.c.googlers.com.notmuch>
Date: Sat, 15 Feb 2025 10:16:07 -0500
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Martin KaFai Lau <martin.lau@...ux.dev>, 
 Jason Xing <kerneljasonxing@...il.com>
Cc: davem@...emloft.net, 
 edumazet@...gle.com, 
 kuba@...nel.org, 
 pabeni@...hat.com, 
 dsahern@...nel.org, 
 willemdebruijn.kernel@...il.com, 
 willemb@...gle.com, 
 ast@...nel.org, 
 daniel@...earbox.net, 
 andrii@...nel.org, 
 eddyz87@...il.com, 
 song@...nel.org, 
 yonghong.song@...ux.dev, 
 john.fastabend@...il.com, 
 kpsingh@...nel.org, 
 sdf@...ichev.me, 
 haoluo@...gle.com, 
 jolsa@...nel.org, 
 horms@...nel.org, 
 bpf@...r.kernel.org, 
 netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next v11 09/12] bpf: add BPF_SOCK_OPS_TS_ACK_OPT_CB
 callback

Martin KaFai Lau wrote:
> On 2/14/25 3:16 PM, Jason Xing wrote:
> > On Sat, Feb 15, 2025 at 4:34 AM Martin KaFai Lau <martin.lau@...ux.dev> wrote:
> >>
> >> On 2/13/25 5:00 PM, Jason Xing wrote:
> >>> diff --git a/net/dsa/user.c b/net/dsa/user.c
> >>> index 291ab1b4acc4..794fe553dd77 100644
> >>> --- a/net/dsa/user.c
> >>> +++ b/net/dsa/user.c
> >>> @@ -897,7 +897,7 @@ static void dsa_skb_tx_timestamp(struct dsa_user_priv *p,
> >>>    {
> >>>        struct dsa_switch *ds = p->dp->ds;
> >>>
> >>> -     if (!(skb_shinfo(skb)->tx_flags & SKBTX_HW_TSTAMP))
> >>> +     if (!(skb_shinfo(skb)->tx_flags & SKBTX_HW_TSTAMP_NOBPF))
> >>
> >> This change should be in patch 8.
> >>
> >> [ ... ]
> >>
> >>> diff --git a/net/socket.c b/net/socket.c
> >>> index 262a28b59c7f..517de433d4bb 100644
> >>> --- a/net/socket.c
> >>> +++ b/net/socket.c
> >>> @@ -676,7 +676,7 @@ void __sock_tx_timestamp(__u32 tsflags, __u8 *tx_flags)
> >>>        u8 flags = *tx_flags;
> >>>
> >>>        if (tsflags & SOF_TIMESTAMPING_TX_HARDWARE) {
> >>> -             flags |= SKBTX_HW_TSTAMP;
> >>> +             flags |= SKBTX_HW_TSTAMP_NOBPF;
> >>
> >> Same here.
> > 
> > Sure, you're right. If you feel it's necessary to re-spin, I will
> > adjust these two points :)
> 
> That will be good. I would wait a bit to collect Willem's comment first.

Depends on answers to my few remaining points.