netdev - Re: [PATCH net-next v2 3/3] selftests: drv-net: add a simple TSO test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250215083121.5bb31524@kernel.org>
Date: Sat, 15 Feb 2025 08:31:21 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
 petrm@...dia.com, stfomichev@...il.com
Subject: Re: [PATCH net-next v2 3/3] selftests: drv-net: add a simple TSO
 test

On Sat, 15 Feb 2025 09:49:26 -0500 Willem de Bruijn wrote:
> > +        cases = []
> > +        for outer_ipv4 in [True, False]:
> > +            for info in test_info:
> > +                # Skip if test which only works for a specific IP version
> > +                if outer_ipv4 == info[1]:  
> 
> Only if need to respin:
> 
> using ternary True, False, None for skip_ipv6, skip_ipv4, skip_neither
> is a bit non-obvious. Use strings?

Now that you say it..
I think using ipver with values "4" "6" could clean up a few things.
I'll poke a little bit on Monday, and probably respin.