netdev - RE: [PATCH bpf-next v10 1/5] xsk: Add launch time hardware offload support to XDP Tx metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH0PR11MB5830178A14BBAB8B65B97A37D8F82@PH0PR11MB5830.namprd11.prod.outlook.com>
Date: Sun, 16 Feb 2025 02:22:01 +0000
From: "Song, Yoong Siang" <yoong.siang.song@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "David S . Miller" <davem@...emloft.net>, Eric Dumazet
	<edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
	<horms@...nel.org>, Willem de Bruijn <willemb@...gle.com>, "Bezdeka, Florian"
	<florian.bezdeka@...mens.com>, Donald Hunter <donald.hunter@...il.com>,
	Jonathan Corbet <corbet@....net>, Bjorn Topel <bjorn@...nel.org>, "Karlsson,
 Magnus" <magnus.karlsson@...el.com>, "Fijalkowski, Maciej"
	<maciej.fijalkowski@...el.com>, Jonathan Lemon <jonathan.lemon@...il.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, Alexei Starovoitov <ast@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>, Jesper Dangaard Brouer
	<hawk@...nel.org>, John Fastabend <john.fastabend@...il.com>, "Damato, Joe"
	<jdamato@...tly.com>, Stanislav Fomichev <sdf@...ichev.me>, Xuan Zhuo
	<xuanzhuo@...ux.alibaba.com>, Mina Almasry <almasrymina@...gle.com>, "Daniel
 Jurgens" <danielj@...dia.com>, Andrii Nakryiko <andrii@...nel.org>, "Eduard
 Zingerman" <eddyz87@...il.com>, Mykola Lysenko <mykolal@...com>, "Martin
 KaFai Lau" <martin.lau@...ux.dev>, Song Liu <song@...nel.org>, Yonghong Song
	<yonghong.song@...ux.dev>, KP Singh <kpsingh@...nel.org>, Hao Luo
	<haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>, Shuah Khan
	<shuah@...nel.org>, Alexandre Torgue <alexandre.torgue@...s.st.com>, "Jose
 Abreu" <joabreu@...opsys.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>,
	"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, Faizal Rahim
	<faizal.abdul.rahim@...ux.intel.com>, Choong Yong Liang
	<yong.liang.choong@...ux.intel.com>, "Bouska, Zdenek"
	<zdenek.bouska@...mens.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-doc@...r.kernel.org"
	<linux-doc@...r.kernel.org>, "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
	"linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
	"linux-stm32@...md-mailman.stormreply.com"
	<linux-stm32@...md-mailman.stormreply.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>, "xdp-hints@...-project.net"
	<xdp-hints@...-project.net>
Subject: RE: [PATCH bpf-next v10 1/5] xsk: Add launch time hardware offload
 support to XDP Tx metadata

On Sunday, February 16, 2025 3:04 AM, Jakub Kicinski <kuba@...nel.org> wrote:
>On Sat, 15 Feb 2025 11:01:59 -0800 Jakub Kicinski wrote:
>> On Fri,  7 Feb 2025 10:19:39 +0800 Song Yoong Siang wrote:
>> > Extend the XDP Tx metadata framework so that user can requests launch time
>> > hardware offload, where the Ethernet device will schedule the packet for
>> > transmission at a pre-determined time called launch time. The value of
>> > launch time is communicated from user space to Ethernet driver via
>> > launch_time field of struct xsk_tx_metadata.
>>
>> Acked-by: Jakub Kicinski <kuba@...nel.org>
>
>Sorry, I take that back, you haven't regenerated the code after
>renaming the flag:
>

Hi Jakub,

Thank you for your review and for catching that mistake.
I will rework the patch and submit a new version.

Thanks and regards,
Siang

>diff --git a/include/uapi/linux/netdev.h b/include/uapi/linux/netdev.h
>index fc0aa971d276..b97ff8bbb0c6 100644
>--- a/include/uapi/linux/netdev.h
>+++ b/include/uapi/linux/netdev.h
>@@ -59,13 +59,13 @@ enum netdev_xdp_rx_metadata {
>  *   by the driver.
>  * @NETDEV_XSK_FLAGS_TX_CHECKSUM: L3 checksum HW offload is supported by the
>  *   driver.
>- * @NETDEV_XSK_FLAGS_LAUNCH_TIME: Launch Time HW offload is supported by the
>- *   driver.
>+ * @NETDEV_XSK_FLAGS_TX_LAUNCH_TIME_FIFO: Launch time HW offload is supported
>+ *   by the driver.
>  */
> enum netdev_xsk_flags {
>        NETDEV_XSK_FLAGS_TX_TIMESTAMP = 1,
>        NETDEV_XSK_FLAGS_TX_CHECKSUM = 2,
>-       NETDEV_XSK_FLAGS_LAUNCH_TIME = 4,
>+       NETDEV_XSK_FLAGS_TX_LAUNCH_TIME_FIFO = 4,
> };
>
> enum netdev_queue_type {
>diff --git a/tools/include/uapi/linux/netdev.h b/tools/include/uapi/linux/netdev.h
>index fc0aa971d276..b97ff8bbb0c6 100644
>--- a/tools/include/uapi/linux/netdev.h
>+++ b/tools/include/uapi/linux/netdev.h
>@@ -59,13 +59,13 @@ enum netdev_xdp_rx_metadata {
>  *   by the driver.
>  * @NETDEV_XSK_FLAGS_TX_CHECKSUM: L3 checksum HW offload is supported by the
>  *   driver.
>- * @NETDEV_XSK_FLAGS_LAUNCH_TIME: Launch Time HW offload is supported by the
>- *   driver.
>+ * @NETDEV_XSK_FLAGS_TX_LAUNCH_TIME_FIFO: Launch time HW offload is supported
>+ *   by the driver.
>  */
> enum netdev_xsk_flags {
>        NETDEV_XSK_FLAGS_TX_TIMESTAMP = 1,
>        NETDEV_XSK_FLAGS_TX_CHECKSUM = 2,
>-       NETDEV_XSK_FLAGS_LAUNCH_TIME = 4,
>+       NETDEV_XSK_FLAGS_TX_LAUNCH_TIME_FIFO = 4,
> };
>
> enum netdev_queue_type {