netdev - Re: [PATCH net-next v3 00/12] net: Hold netdev instance lock during ndo operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z7NTE1DlI0nQjjwy@mini-arch>
Date: Mon, 17 Feb 2025 07:17:39 -0800
From: Stanislav Fomichev <stfomichev@...il.com>
To: Stanislav Fomichev <sdf@...ichev.me>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com,
	Saeed Mahameed <saeed@...nel.org>
Subject: Re: [PATCH net-next v3 00/12] net: Hold netdev instance lock during
 ndo operations

On 02/16, Stanislav Fomichev wrote:
> As the gradual purging of rtnl continues, start grabbing netdev
> instance lock in more places so we can get to the state where
> most paths are working without rtnl. Start with requiring the
> drivers that use shaper api (and later queue mgmt api) to work
> with both rtnl and netdev instance lock. Eventually we might
> attempt to drop rtnl. This mostly affects iavf, gve, bnxt and
> netdev sim (as the drivers that implement shaper/queue mgmt)
> so those drivers are converted in the process.
> 
> call_netdevice_notifiers locking is very inconsistent and might need
> a separate follow up. Some notified events are covered by the
> instance lock, some are not, which might complicate the driver
> expectations.
> 
> Changes since v2:
> - new patch to replace dev_addr_sem with instance lock (forwarding tests)
> - CONFIG_LOCKDEP around netdev_lock_cmp_fn (Jakub)
> - remove netif_device_present check from dev_setup_tc (bpf_offload.py)
> - reorder bpf_devs_locks and instance lock ordering in bpf map
>   offload (bpf_offload.py)
> 
> Changes since v1:
> - fix netdev_set_mtu_ext_locked in the wrong place (lkp@...el.com)
> - add missing depend on CONFIG_NET_SHAPER for dummy device
>   (lkp@...el.com)
>   - not sure we need to apply dummy device patch..
> - need_netdev_ops_lock -> netdev_need_ops_lock (Jakub)
> - remove netdev_assert_locked near napi_xxx_locked calls (Jakub)
> - fix netdev_lock_cmp_fn comment and line length (Jakub)
> - fix kdoc style of dev_api.c routines (Jakub)
> - reflow dev_setup_tc to avoid indent (Jakub)
> - keep tc_can_offload checks outside of dev_setup_tc (Jakub)
> 
> Changes since RFC:
> - other control paths are protected
> - bntx has been converted to mostly depend on netdev instance lock

Teaming lock ordering is still not correct :-(

---
pw-bot: cr