netdev - Re: [PATCH net-next v3 00/12] net: Hold netdev instance lock during ndo operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z7N8QgXWP-DJU5Yg@mini-arch>
Date: Mon, 17 Feb 2025 10:13:22 -0800
From: Stanislav Fomichev <stfomichev@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Stanislav Fomichev <sdf@...ichev.me>, netdev@...r.kernel.org,
	davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
	Saeed Mahameed <saeed@...nel.org>
Subject: Re: [PATCH net-next v3 00/12] net: Hold netdev instance lock during
 ndo operations

On 02/17, Jakub Kicinski wrote:
> On Mon, 17 Feb 2025 07:17:39 -0800 Stanislav Fomichev wrote:
> > Teaming lock ordering is still not correct :-(
> 
> Mm, yeah, looks like patch 9. We need to tell lockdep team's netdev
> lock is not the same one as the lower netdev lock. Probably gotta
> add the instance lock to netdev_lockdep_set_classes() after all?

Adding it to netdev_lockdep_set_classes triggers cleanup_net lockdep
warning. Not sure why my lock_set_cmp_fn doesn't help with that, will
try to debug.