netdev - Re: [net v1] devlink: fix xa_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b5ea6709-929b-4b42-b73b-69c4e8594af1@stanley.mountain>
Date: Mon, 17 Feb 2025 10:46:58 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Andrew Lunn <andrew@...n.ch>
Cc: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
	netdev@...r.kernel.org, jiri@...nulli.us, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	horms@...nel.org, pierre@...ckhpc.com,
	Dan Carpenter <error27@...il.com>
Subject: Re: [net v1] devlink: fix xa_alloc_cyclic error handling

On Sun, Feb 16, 2025 at 05:08:23PM +0100, Andrew Lunn wrote:
>  * Returns negative errno, 0 if there was no change, and 1 in case of change
> 
> So there is the potential for the same issue with
> mdiobus_modify_changed(), phy_modify_changed(),
> phy_modify_mmd_changed(), phy_modify_paged_changed(). Hope this helps
> with testing.

Thanks, that's useful.

The first check would have caught all these, but the second one would
only have caught the first three.  The combined check will catch them
all.  :)

regards,
dan carpenter