netdev - Re: [PATCH net-next v2 1/2] usb: Add base USB MCTP definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025021758-negate-entwine-5d40@gregkh>
Date: Mon, 17 Feb 2025 10:02:41 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Jeremy Kerr <jk@...econstruct.com.au>
Cc: Matt Johnston <matt@...econstruct.com.au>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	Santosh Puranik <spuranik@...dia.com>
Subject: Re: [PATCH net-next v2 1/2] usb: Add base USB MCTP definitions

On Mon, Feb 17, 2025 at 04:55:59PM +0800, Jeremy Kerr wrote:
> Hi Greg,
> 
> > > --- /dev/null
> > > +++ b/include/linux/usb/mctp-usb.h
> > > @@ -0,0 +1,30 @@
> > > +/* SPDX-License-Identifier: GPL-2.0+ */
> > 
> > I missed this the last time, sorry, but I have to ask, do you really
> > mean v2 or later?  If so, that's fine, just want to make sure.
> 
> I'm fine with 2.0+, but I figure the preference is consistency here. So,
> since I'm doing a v3, I will send that out with GPL-2.0.
> 
> > Whichever you pick is fine with me, so:
> > 
> > Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> Thanks! v3 will have the __u8s changed to u8, as Jakub has requested.
> Would you like me to keep the Ack on that?

Yes, that's fine.  But to be fair, "__u8" is correct here as that's what
the endpoint variable is as well (it is coming directly from hardware),
but I'm not going to complain about that as it really doesn't matter :)

thanks,

greg k-h