netdev - Re: [PATCH net-next V4] eth: fbnic: Add ethtool support for IRQ coalescing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH-L+nPbwKuHOmeNVZ7Vn8OOxhVNodADOvR7yF2SaMf=WXVLXA@mail.gmail.com>
Date: Tue, 18 Feb 2025 13:47:47 +0530
From: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@...adcom.com>
To: Mohsin Bashir <mohsin.bashr@...il.com>
Cc: netdev@...r.kernel.org, alexanderduyck@...com, kuba@...nel.org, 
	andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com, 
	pabeni@...hat.com, linux@...linux.org.uk, sanman.p211993@...il.com, 
	vadim.fedorenko@...ux.dev, suhui@...china.com, sdf@...ichev.me, 
	jdamato@...tly.com, brett.creeley@....com, aleksander.lobakin@...el.com, 
	kernel-team@...a.com, Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net-next V4] eth: fbnic: Add ethtool support for IRQ coalescing

On Tue, Feb 18, 2025 at 8:06 AM Mohsin Bashir <mohsin.bashr@...il.com> wrote:
>
> Add ethtool support to configure the IRQ coalescing behavior. Support
> separate timers for Rx and Tx for time based coalescing. For frame based
> configuration, currently we only support the Rx side.
>
> The hardware allows configuration of descriptor count instead of frame
> count requiring conversion between the two. We assume 2 descriptors
> per frame, one for the metadata and one for the data segment.
>
> When rx-frames are not configured, we set the RX descriptor count to
> half the ring size as a fail safe.
>
> Default configuration:
> ethtool -c eth0 | grep -E "rx-usecs:|tx-usecs:|rx-frames:"
> rx-usecs:       30
> rx-frames:      0
> tx-usecs:       35
>
> IRQ rate test:
> With single iperf flow we monitor IRQ rate while changing the tx-usesc and
> rx-usecs to high and low values.
>
> ethtool -C eth0 rx-frames 8192 rx-usecs 150 tx-usecs 150
> irq/sec   13k
> irq/sec   14k
> irq/sec   14k
>
> ethtool -C eth0 rx-frames 8192 rx-usecs 10 tx-usecs 10
> irq/sec  27k
> irq/sec  28k
> irq/sec  28k
>
> Validating the use of extack:
> ethtool -C eth0 rx-frames 16384
> netlink error: fbnic: rx_frames is above device max
> netlink error: Invalid argument
>
> Signed-off-by: Mohsin Bashir <mohsin.bashr@...il.com>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Reviewed-by: Brett Creeley <brett.creeley@....com>

LGTM,
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@...adcom.com>


-- 
Regards,
Kalesh AP

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4239 bytes)