netdev - Re: [PATCH] selftests: net: Fix minor typos in MPTCP and psock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAO9wTFgjZ+in3ypHCKGOtY=K7DBBfJy82d6gXw=4mqJG4vtOjw@mail.gmail.com>
Date: Tue, 18 Feb 2025 14:58:39 +0530
From: Suchit K <suchitkarunakaran@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Matthieu Baerts <matttbe@...nel.org>, netdev@...r.kernel.org, horms@...nel.org, 
	linux-kernel-mentees@...ts.linux.dev, linux-kernel@...r.kernel.org, 
	skhan@...uxfoundation.org
Subject: Re: [PATCH] selftests: net: Fix minor typos in MPTCP and
 psock_tpacket tests

Hi Jakub. I've reposted the patch. Thanks.

On Tue, 18 Feb 2025 at 05:07, Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Mon, 17 Feb 2025 11:08:36 +0100 Matthieu Baerts wrote:
> > On 16/02/2025 13:25, Suchit K wrote:
> > > Fixes minor spelling errors:
> > > - `simult_flows.sh`: "al testcases" → "all testcases"
> > > - `psock_tpacket.c`: "accross" → "across"
> >
> > The modifications in MPTCP (and psock_tpacket) look good to me:
> >
> > Reviewed-by: Matthieu Baerts (NGI0) <matttbe@...nel.org>
>
> Thanks! This patch is corrupted:
>
> Applying: selftests: net: Fix minor typos in MPTCP and psock_tpacket tests
> error: git diff header lacks filename information when removing 1 leading pathname component (line 7)
> Patch failed at 0001 selftests: net: Fix minor typos in MPTCP and psock_tpacket tests
> hint: Use 'git am --show-current-patch=diff' to see the failed patch
> hint: When you have resolved this problem, run "git am --continue".
> hint: If you prefer to skip this patch, run "git am --skip" instead.
> hint: To restore the original branch and stop patching, run "git am --abort".
> hint: Disable this message with "git config set advice.mergeConflict false"
> Waiting for rebase to finish Mon Feb 17 03:34:36 PM PST 2025^C
>
> So repost will be needed (unless Matt wants to take it into his tree
> manually).
>
> > This patch can be applied directly in the netdev tree, but I'm not sure
> > the Netdev maintainers will accept that kind of small clean-up patch
> > alone, see:
> >
> >  https://docs.kernel.org/process/maintainer-netdev.html#clean-up-patches
>
> FWIW spelling problems are explicitly called out as okay there.
> --
> pw-bot: cr