netdev - [PATCH] mlx5: Add check for get_macsec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250218100200.2535141-1-haoxiang_li2024@163.com>
Date: Tue, 18 Feb 2025 18:02:00 +0800
From: Haoxiang Li <haoxiang_li2024@....com>
To: leon@...nel.org,
	jgg@...pe.ca,
	sd@...asysnail.net,
	phaddad@...dia.com
Cc: linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org,
	Haoxiang Li <haoxiang_li2024@....com>,
	stable@...r.kernel.org
Subject: [PATCH] mlx5: Add check for get_macsec_device()

Add check for the return value of get_macsec_device() in
mlx5r_del_gid_macsec_operations() to prevent null pointer
dereference.

Fixes: 58dbd6428a68 ("RDMA/mlx5: Handles RoCE MACsec steering rules addition and deletion")
Cc: stable@...r.kernel.org
Signed-off-by: Haoxiang Li <haoxiang_li2024@....com>
---
 drivers/infiniband/hw/mlx5/macsec.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/infiniband/hw/mlx5/macsec.c b/drivers/infiniband/hw/mlx5/macsec.c
index 3c56eb5eddf3..623b0a58f721 100644
--- a/drivers/infiniband/hw/mlx5/macsec.c
+++ b/drivers/infiniband/hw/mlx5/macsec.c
@@ -354,6 +354,11 @@ void mlx5r_del_gid_macsec_operations(const struct ib_gid_attr *attr)
 		}
 	}
 	macsec_device = get_macsec_device(ndev, &dev->macsec.macsec_devices_list);
+	if (!macsec_device) {
+		dev_put(ndev);
+		mutex_unlock(&dev->macsec.lock);
+		return;
+	}
 	mlx5_macsec_del_roce_rule(attr->index, dev->mdev->macsec_fs,
 				  &macsec_device->tx_rules_list, &macsec_device->rx_rules_list);
 	mlx5_macsec_del_roce_gid(macsec_device, attr->index);
-- 
2.25.1