netdev - Re: [EXTERNAL] Re: [PATCH net-next v2 1/3] net: ti: icssg-prueth: Use page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94425bfd-7f2b-4fc4-86f8-a56e56173d22@ti.com>
Date: Tue, 18 Feb 2025 17:58:27 +0530
From: "Malladi, Meghana" <m-malladi@...com>
To: Diogo Ivo <diogo.ivo@...mens.com>, Roger Quadros <rogerq@...nel.org>,
        <danishanwar@...com>, <pabeni@...hat.com>, <kuba@...nel.org>,
        <edumazet@...gle.com>, <davem@...emloft.net>, <andrew+netdev@...n.ch>
CC: <bpf@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
        <u.kleine-koenig@...libre.com>, <krzysztof.kozlowski@...aro.org>,
        <dan.carpenter@...aro.org>, <schnelle@...ux.ibm.com>,
        <glaroque@...libre.com>, <rdunlap@...radead.org>,
        <jan.kiszka@...mens.com>, <john.fastabend@...il.com>,
        <hawk@...nel.org>, <daniel@...earbox.net>, <ast@...nel.org>,
        <srk@...com>, Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [EXTERNAL] Re: [PATCH net-next v2 1/3] net: ti: icssg-prueth: Use
 page_pool API for RX buffer allocation

Hi Diogo,

On 2/18/2025 5:54 PM, Diogo Ivo wrote:
> Hi Meghana, On 2/18/25 10: 10 AM, Malladi, Meghana wrote: > On 2/12/2025 
> 7: 26 PM, Roger Quadros wrote: >> Can we get rid of SKB entirely from 
> the management channel code? >> The packet received on this channel is 
> never passed to
> ZjQcmQRYFpfptBannerStart
> This message was sent from outside of Texas Instruments.
> Do not click links or open attachments unless you recognize the source 
> of this email and know the content is safe.
> Report Suspicious
> <https://us-phishalarm-ewt.proofpoint.com/EWT/v1/G3vK! 
> uvdgfB3F_Ow7QIXEnBKj3ybYT8I9yL0CM5RLkel44YW99zMeqk_TnCBkOwR0q45N5dLjtBz49EalJyUJ1-U1lPk6DIBve_3-$>
> ZjQcmQRYFpfptBannerEnd
> 
> Hi Meghana,
> 
> On 2/18/25 10:10 AM, Malladi, Meghana wrote:
>> On 2/12/2025 7:26 PM, Roger Quadros wrote:
>>> Can we get rid of SKB entirely from the management channel code?
>>> The packet received on this channel is never passed to user space so
>>> I don't see why SKB is required.
>>>
>> 
>> Yes I do agree with you on the fact the SKB here is not passed to the 
>> network stack, hence this is redundant. But honestly I am not sure how 
>> that can be done, because the callers of this function access skb->data
>> from the skb which is returned and the same can't be done with page (how 
>> to pass the same data using page?)
>> Also as you are aware we are not currently supporting SR1 devices 
>> anymore, hence I don't have any SR1 devices handy to test these changes 
>> and ensure nothing is broken if I remove SKB entirely.
> 
> I have some SR1 devices available and would be happy to test these
> proposed changes in case they are feasible.
> 

That's awesome. Once the changes have been aligned with Roger, I will 
share the changes with you for testing before posting v3. Thanks for 
your support.

> Best regards,
> Diogo
>