netdev - Re: [PATCH bpf-next v12 05/12] net-timestamp: prepare for isolating two modes of SO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67b497d631344_10d6a3294bd@willemb.c.googlers.com.notmuch>
Date: Tue, 18 Feb 2025 09:23:18 -0500
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Jason Xing <kerneljasonxing@...il.com>, 
 davem@...emloft.net, 
 edumazet@...gle.com, 
 kuba@...nel.org, 
 pabeni@...hat.com, 
 dsahern@...nel.org, 
 willemdebruijn.kernel@...il.com, 
 willemb@...gle.com, 
 ast@...nel.org, 
 daniel@...earbox.net, 
 andrii@...nel.org, 
 martin.lau@...ux.dev, 
 eddyz87@...il.com, 
 song@...nel.org, 
 yonghong.song@...ux.dev, 
 john.fastabend@...il.com, 
 kpsingh@...nel.org, 
 sdf@...ichev.me, 
 haoluo@...gle.com, 
 jolsa@...nel.org, 
 shuah@...nel.org, 
 ykolal@...com
Cc: bpf@...r.kernel.org, 
 netdev@...r.kernel.org, 
 Jason Xing <kerneljasonxing@...il.com>
Subject: Re: [PATCH bpf-next v12 05/12] net-timestamp: prepare for isolating
 two modes of SO_TIMESTAMPING

Jason Xing wrote:
> No functional changes here. Only add test to see if the orig_skb
> matches the usage of application SO_TIMESTAMPING.
> 
> In this series, bpf timestamping and previous socket timestamping
> are implemented in the same function __skb_tstamp_tx(). To test
> the socket enables socket timestamping feature, this function
> skb_tstamp_tx_report_so_timestamping() is added.
> 
> In the next patch, another check for bpf timestamping feature
> will be introduced just like the above report function, namely,
> skb_tstamp_tx_report_bpf_timestamping(). Then users will be able
> to know the socket enables either or both of features.
> 
> Signed-off-by: Jason Xing <kerneljasonxing@...il.com>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>