netdev - Re: [PATCH v14 07/11] io_uring/zcrx: set pp memory provider for an rx queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc1b81b3-f02c-46d0-b4be-34bba23d20c7@ijzerbout.nl>
Date: Tue, 18 Feb 2025 20:40:57 +0100
From: Kees Bakker <kees@...erbout.nl>
To: David Wei <dw@...idwei.uk>, io-uring@...r.kernel.org,
 netdev@...r.kernel.org
Cc: Jens Axboe <axboe@...nel.dk>, Pavel Begunkov <asml.silence@...il.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jesper Dangaard Brouer <hawk@...nel.org>, David Ahern <dsahern@...nel.org>,
 Mina Almasry <almasrymina@...gle.com>,
 Stanislav Fomichev <stfomichev@...il.com>, Joe Damato <jdamato@...tly.com>,
 Pedro Tammela <pctammela@...atatu.com>, lizetao <lizetao1@...wei.com>
Subject: Re: [PATCH v14 07/11] io_uring/zcrx: set pp memory provider for an rx
 queue

Op 15-02-2025 om 01:09 schreef David Wei:
> Set the page pool memory provider for the rx queue configured for zero
> copy to io_uring. Then the rx queue is reset using
> netdev_rx_queue_restart() and netdev core + page pool will take care of
> filling the rx queue from the io_uring zero copy memory provider.
>
> For now, there is only one ifq so its destruction happens implicitly
> during io_uring cleanup.
>
> Reviewed-by: Jens Axboe <axboe@...nel.dk>
> Signed-off-by: David Wei <dw@...idwei.uk>
> ---
>   io_uring/zcrx.c | 49 +++++++++++++++++++++++++++++++++++++++++--------
>   1 file changed, 41 insertions(+), 8 deletions(-)
>
> diff --git a/io_uring/zcrx.c b/io_uring/zcrx.c
> index 8833879d94ba..7d24fc98b306 100644
> --- a/io_uring/zcrx.c
> +++ b/io_uring/zcrx.c
> [...]
> @@ -444,6 +475,8 @@ void io_shutdown_zcrx_ifqs(struct io_ring_ctx *ctx)
>   
>   	if (ctx->ifq)
>   		io_zcrx_scrub(ctx->ifq);
> +
> +	io_close_queue(ctx->ifq);
If ctx->ifq is NULL (which seems to be not unlikely given the if 
statement above)
then you'll get a NULL pointer dereference in io_close_queue().
>   }
>   
>   static inline u32 io_zcrx_rqring_entries(struct io_zcrx_ifq *ifq)