netdev - Re: [PATCH net-next v3 5/5] selftests: drv-net-hw: Add a test for symmetric RSS hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9eb3db1a-514b-4fcc-8318-7af0bd0a62df@nvidia.com>
Date: Tue, 18 Feb 2025 22:26:25 +0200
From: Gal Pressman <gal@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>, Jonathan Corbet <corbet@....net>,
 Tony Nguyen <anthony.l.nguyen@...el.com>,
 Przemek Kitszel <przemyslaw.kitszel@...el.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, Tariq Toukan <tariqt@...dia.com>,
 Edward Cree <ecree.xilinx@...il.com>, Ahmed Zaki <ahmed.zaki@...el.com>,
 linux-doc@...r.kernel.org, Nimrod Oren <noren@...dia.com>
Subject: Re: [PATCH net-next v3 5/5] selftests: drv-net-hw: Add a test for
 symmetric RSS hash

On 18/02/2025 2:19, Jakub Kicinski wrote:
> Wouldn't it be both faster and less error prone to test this with UDP
> sockets?
> 
> 	sock = socket.socket(socket.AF_INET6, socket.SOCK_DGRAM)
> 	sock.connect(cfg.remove_addr_v[ipver], remote_port)
> 	sock.recvmsg(100)
> 
> 	tgt = f"{ipver}:{cfg.addr_v[ipver]}:{local_port},sourceport={remote_port}"
> 	cmd("echo a | socat - UDP" + tgt, host=cfg.remote)
> 
> 	cpu = sock.getsockopt(socket.SOL_SOCKET, socket.SO_INCOMING_CPU)
> 
> Run this for 10 pairs for ports, make sure we hit at least 2 CPUs,
> and that the CPUs match for each pair.

Thanks, I can do that.

> 
> Would be good to test both IPv4 and IPv6. I'm going to merge:
>   https://lore.kernel.org/all/20250217194200.3011136-4-kuba@kernel.org/
> it should make writing the v4 + v6 test combos easier.

Should I wait for it to get merged?