netdev - Re: [PATCH iwl-next v2 0/4] igb: XDP/ZC follow up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z7T5G9ZQRBb4EtdG@LQ3V64L9R2>
Date: Tue, 18 Feb 2025 16:18:19 -0500
From: Joe Damato <jdamato@...tly.com>
To: Kurt Kanzenbach <kurt@...utronix.de>
Cc: Tony Nguyen <anthony.l.nguyen@...el.com>,
	Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Gerhard Engleder <gerhard@...leder-embedded.com>,
	intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org
Subject: Re: [PATCH iwl-next v2 0/4] igb: XDP/ZC follow up

On Mon, Feb 17, 2025 at 12:31:20PM +0100, Kurt Kanzenbach wrote:
> This is a follow up for the igb XDP/ZC implementation. The first two 
> patches link the IRQs and queues to NAPI instances. This is required to 
> bring back the XDP/ZC busy polling support. The last patch removes 
> undesired IRQs (injected via igb watchdog) while busy polling with 
> napi_defer_hard_irqs and gro_flush_timeout set.
> 
> Signed-off-by: Kurt Kanzenbach <kurt@...utronix.de>
> ---
> Changes in v2:
> - Take RTNL lock in PCI error handlers (Joe)
> - Fix typo in commit message (Gerhard)
> - Use netif_napi_add_config() (Joe)
> - Link to v1: https://lore.kernel.org/r/20250210-igb_irq-v1-0-bde078cdb9df@linutronix.de

Thanks for sending a v2.

My comment from the previous series still stands, which simply that
I have no idea if the maintainers will accept changes using this API
or prefer to wait until Stanislav's work [1] is completed to remove
the RTNL requirement from this API altogether.

[1]: https://lore.kernel.org/netdev/20250218020948.160643-1-sdf@fomichev.me/