netdev - Re: [PATCH net-next 4/4] net/mlx5: Add sensor name to temperature event message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250217162719.1e20afac@kernel.org>
Date: Mon, 17 Feb 2025 16:27:19 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Tariq Toukan <tariqt@...dia.com>
Cc: Simon Horman <horms@...nel.org>, "David S. Miller"
 <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, Eric Dumazet
 <edumazet@...gle.com>, Andrew Lunn <andrew+netdev@...n.ch>, Shahar Shitrit
 <shshitrit@...dia.com>, Gal Pressman <gal@...dia.com>, Saeed Mahameed
 <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>,
 netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
 linux-kernel@...r.kernel.org, Carolina Jubran <cjubran@...dia.com>
Subject: Re: [PATCH net-next 4/4] net/mlx5: Add sensor name to temperature
 event message

On Sat, 15 Feb 2025 19:29:35 +0000 Simon Horman wrote:
> > +	for_each_set_bit(i, bit_set_ptr, num_bits) {
> > +		const char *sensor_name = hwmon_get_sensor_name(hwmon, i + bit_set_offset);
> > +
> > +		mlx5_core_warn(dev, "Sensor name[%d]: %s\n", i + bit_set_offset, sensor_name);
> > +	}
> > +}  
> 
> nit:
> 
> If you have to respin for some other reason, please consider limiting lines
> to 80 columns wide or less here and elsewhere in this patch where it
> doesn't reduce readability (subjective I know).

+1, please try to catch such situations going forward