netdev - Re: [PATCH net-next 0/4] selftests: drv-net: improve the queue test for XSK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z7T7vVZgvqt-DOVC@mini-arch>
Date: Tue, 18 Feb 2025 13:29:33 -0800
From: Stanislav Fomichev <stfomichev@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
	shuah@...nel.org, hawk@...nel.org, petrm@...dia.com,
	jdamato@...tly.com, willemdebruijn.kernel@...il.com
Subject: Re: [PATCH net-next 0/4] selftests: drv-net: improve the queue test
 for XSK

On 02/18, Jakub Kicinski wrote:
> We see some flakes in the the XSK test:
> 
>    Exception| Traceback (most recent call last):
>    Exception|   File "/home/virtme/testing-18/tools/testing/selftests/net/lib/py/ksft.py", line 218, in ksft_run
>    Exception|     case(*args)
>    Exception|   File "/home/virtme/testing-18/tools/testing/selftests/drivers/net/./queues.py", line 53, in check_xdp
>    Exception|     ksft_eq(q['xsk'], {})
>    Exception| KeyError: 'xsk'
> 
> I think it's because the method or running the helper in the background
> is racy. Add more solid infra for waiting for a background helper to be
> initialized.
> 
> Jakub Kicinski (4):
>   selftests: drv-net: use cfg.rpath() in netlink xsk attr test
>   selftests: drv-net: add a way to wait for a local process
>   selftests: drv-net: improve the use of ksft helpers in XSK queue test
>   selftests: drv-net: rename queues check_xdp to check_xsk
> 
>  .../selftests/drivers/net/xdp_helper.c        | 22 ++++++-
>  tools/testing/selftests/drivers/net/queues.py | 55 ++++++++----------
>  tools/testing/selftests/net/lib/py/ksft.py    |  5 ++
>  tools/testing/selftests/net/lib/py/utils.py   | 58 +++++++++++++++++--
>  4 files changed, 103 insertions(+), 37 deletions(-)
> 
> -- 
> 2.48.1
> 

Acked-by: Stanislav Fomichev <sdf@...ichev.me>