netdev - Re: [PATCH net v4 1/2] net: Add non-RCU dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250217163256.491b7990@kernel.org>
Date: Mon, 17 Feb 2025 16:32:56 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Breno Leitao <leitao@...ian.org>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
 <horms@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>, David Ahern
 <dsahern@...nel.org>, linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
 Eric Dumazet <eric.dumazet@...il.com>, kuniyu@...zon.co.jp,
 ushankar@...estorage.com, kuniyu@...zon.com
Subject: Re: [PATCH net v4 1/2] net: Add non-RCU dev_getbyhwaddr() helper

On Thu, 13 Feb 2025 04:42:37 -0800 Breno Leitao wrote:
> +static bool dev_comp_addr(struct net_device *dev, unsigned short type,

sorry for the nit, but: dev_comp_addr() -> dev_addr_cmp() ?

cmp is the typical abbreviation for compare in C

> + * dev_getbyhwaddr - find a device by its hardware address

another tiny nit here: I think ideally there should be a () after the
function name
-- 
pw-bot: cr