netdev - Re: [PATCH net-next 4/4] net/mlx5: Add sensor name to temperature event message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8369b884-71c9-495a-8a1f-ab8ca4ee5f59@gmail.com>
Date: Wed, 19 Feb 2025 15:00:57 +0200
From: Tariq Toukan <ttoukan.linux@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, Tariq Toukan <tariqt@...dia.com>
Cc: Simon Horman <horms@...nel.org>, "David S. Miller" <davem@...emloft.net>,
 Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, Shahar Shitrit <shshitrit@...dia.com>,
 Gal Pressman <gal@...dia.com>, Saeed Mahameed <saeedm@...dia.com>,
 Leon Romanovsky <leon@...nel.org>, netdev@...r.kernel.org,
 linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
 Carolina Jubran <cjubran@...dia.com>
Subject: Re: [PATCH net-next 4/4] net/mlx5: Add sensor name to temperature
 event message

On 18/02/2025 2:27, Jakub Kicinski wrote:
> On Sat, 15 Feb 2025 19:29:35 +0000 Simon Horman wrote:
>>> +	for_each_set_bit(i, bit_set_ptr, num_bits) {
>>> +		const char *sensor_name = hwmon_get_sensor_name(hwmon, i + bit_set_offset);
>>> +
>>> +		mlx5_core_warn(dev, "Sensor name[%d]: %s\n", i + bit_set_offset, sensor_name);
>>> +	}
>>> +}
>>
>> nit:
>>
>> If you have to respin for some other reason, please consider limiting lines
>> to 80 columns wide or less here and elsewhere in this patch where it
>> doesn't reduce readability (subjective I know).
> 
> +1, please try to catch such situations going forward
> 

Hi Jakub,

This was not missed.
This is not a new thing...
We've been enforcing a max line length of 100 chars in mlx5 driver for 
the past few years.
I don't have the full image now, but I'm convinced that this dates back 
to an agreement between the mlx5 and netdev maintainers at that time.

80 chars could be too restrictive, especially with today's large 
monitors, while 100-chars is still highly readable.
This is subjective of course...

If you don't have a strong preference, we'll keep the current 100 chars 
limit. Otherwise, just let me know and we'll start enforcing the 
80-chars limit for future patches.

Regards,
Tariq