netdev - Re: [PATCH] net: phy: qt2025: Fix hardware revision check comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c83a4d5f-3e98-4fec-a84a-669f04677774@lunn.ch>
Date: Wed, 19 Feb 2025 14:00:39 +0100
From: Andrew Lunn <andrew@...n.ch>
To: FUJITA Tomonori <fujita.tomonori@...il.com>
Cc: charmitro@...teo.net, tmgross@...ch.edu, hkallweit1@...il.com,
	linux@...linux.org.uk, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: phy: qt2025: Fix hardware revision check comment

On Wed, Feb 19, 2025 at 10:02:00AM +0900, FUJITA Tomonori wrote:
> On Mon, 17 Feb 2025 23:53:50 +0000
> Charalampos Mitrodimas <charmitro@...teo.net> wrote:
> 
> > Correct the hardware revision check comment in the QT2025 driver. The
> > revision value was documented as 0x3b instead of the correct 0xb3,
> > which matches the actual comparison logic in the code.
> > 
> > Signed-off-by: Charalampos Mitrodimas <charmitro@...teo.net>
> > ---
> >  drivers/net/phy/qt2025.rs | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/phy/qt2025.rs b/drivers/net/phy/qt2025.rs
> > index 1ab065798175b4f54c5f2fd6c871ba2942c48bf1..7e754d5d71544c6d6b6a6d90416a5a130ba76108 100644
> > --- a/drivers/net/phy/qt2025.rs
> > +++ b/drivers/net/phy/qt2025.rs
> > @@ -41,7 +41,7 @@ impl Driver for PhyQT2025 {
> >  
> >      fn probe(dev: &mut phy::Device) -> Result<()> {
> >          // Check the hardware revision code.
> > -        // Only 0x3b works with this driver and firmware.
> > +        // Only 0xb3 works with this driver and firmware.
> >          let hw_rev = dev.read(C45::new(Mmd::PMAPMD, 0xd001))?;
> >          if (hw_rev >> 8) != 0xb3 {
> >              return Err(code::ENODEV);
> 
> Oops,
> 
> Reviewed-by: FUJITA Tomonori <fujita.tomonori@...il.com>
> 
> Given that this patch is expected to be merged via netdev, you might
> need to resend with a proper subject:
> 
> https://elixir.bootlin.com/linux/v6.13/source/Documentation/process/maintainer-netdev.rst

Please also include a Fixes: tag.

	Andrew