netdev - Re: [PATCH net v2] net: phy: qt2025: Fix hardware revision check comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4bf73cd3-6504-4ead-9405-0e28b2666088@lunn.ch>
Date: Wed, 19 Feb 2025 14:56:13 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Charalampos Mitrodimas <charmitro@...teo.net>
Cc: FUJITA Tomonori <fujita.tomonori@...il.com>,
	Trevor Gross <tmgross@...ch.edu>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, rust-for-linux@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2] net: phy: qt2025: Fix hardware revision check
 comment

On Wed, Feb 19, 2025 at 12:41:55PM +0000, Charalampos Mitrodimas wrote:
> Correct the hardware revision check comment in the QT2025 driver. The
> revision value was documented as 0x3b instead of the correct 0xb3,
> which matches the actual comparison logic in the code.
> 
> Fixes: fd3eaad826da ("net: phy: add Applied Micro QT2025 PHY driver")
> Reviewed-by: FUJITA Tomonori <fujita.tomonori@...il.com>
> Signed-off-by: Charalampos Mitrodimas <charmitro@...teo.net>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew