netdev - Re: [net PATCH] net: phy: qcom: qca807x fix condition for DAC_DSP_BIAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c234dd4-6bc4-4cbc-acfd-0607d95308ec@lunn.ch>
Date: Wed, 19 Feb 2025 14:59:10 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Maxime Chevallier <maxime.chevallier@...tlin.com>,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	"Rob Herring (Arm)" <robh@...nel.org>,
	Robert Marko <robimarko@...il.com>,
	Christophe JAILLET <christophe.jaillet@...adoo.fr>,
	George Moussalem <george.moussalem@...look.com>,
	linux-arm-msm@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [net PATCH] net: phy: qcom: qca807x fix condition for
 DAC_DSP_BIAS_CURRENT

On Wed, Feb 19, 2025 at 02:09:21PM +0100, Christian Marangi wrote:
> From: George Moussalem <george.moussalem@...look.com>
> 
> While setting the DAC value, the wrong boolean value is evaluated to set
> the DSP bias current. So let's correct the conditional statement and use
> the right boolean value read from the DTS set in the priv.
> 
> Cc: stable@...r.kernel.org
> Fixes: d1cb613efbd3 ("net: phy: qcom: add support for QCA807x PHY Family")
> Signed-off-by: George Moussalem <george.moussalem@...look.com>
> Signed-off-by: Christian Marangi <ansuelsmth@...il.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew