netdev - RE: [EXTERNAL] [PATCH] [net-next v2] octeontx2: hide unused label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SJ0PR18MB5216A3F2CB8D6EF286A7ED9DDBC52@SJ0PR18MB5216.namprd18.prod.outlook.com>
Date: Wed, 19 Feb 2025 18:00:58 +0000
From: Suman Ghosh <sumang@...vell.com>
To: Arnd Bergmann <arnd@...nel.org>,
        Sunil Kovvuri Goutham
	<sgoutham@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Subbaraya
 Sundeep Bhatta <sbhatta@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>,
        Bharat Bhushan <bbhushan2@...vell.com>
CC: Arnd Bergmann <arnd@...db.de>, Andrew Lunn <andrew+netdev@...n.ch>,
        "David
 S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Simon Horman
	<horms@...nel.org>,
        Sai Krishna Gajula <saikrishnag@...vell.com>,
        Nithin
 Kumar Dabilpuram <ndabilpuram@...vell.com>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [EXTERNAL] [PATCH] [net-next v2] octeontx2: hide unused label

> drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 2 ++
>drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c | 2 ++
> 2 files changed, 4 insertions(+)
>
>diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
>b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
>index c7c562f0f5e5..cfed9ec5b157 100644
>--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
>+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
>@@ -3214,8 +3214,10 @@ static int otx2_probe(struct pci_dev *pdev, const
>struct pci_device_id *id)
>
> 	return 0;
>
>+#ifdef CONFIG_DCB
> err_free_zc_bmap:
> 	bitmap_free(pf->af_xdp_zc_qidx);
>+#endif
> err_sriov_cleannup:
> 	otx2_sriov_vfcfg_cleanup(pf);
> err_pf_sriov_init:
>diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c
>b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c
>index 63ddd262d122..7ef3ba477d49 100644
>--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c
>+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c
>@@ -737,8 +737,10 @@ static int otx2vf_probe(struct pci_dev *pdev, const
>struct pci_device_id *id)
>
> 	return 0;
>
>+#ifdef CONFIG_DCB
> err_free_zc_bmap:
> 	bitmap_free(vf->af_xdp_zc_qidx);
>+#endif
> err_unreg_devlink:
> 	otx2_unregister_dl(vf);
> err_shutdown_tc:
>--
>2.39.5
[Suman] Thanks for the patch, looks good to me.
Reviewed-by: Suman Ghosh <sumang@...vell.com>