netdev - Re: [RESEND PATCH net-next 3/5] dt-bindings: net: Add Realtek MDIO controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f051fd62-4762-412e-a11e-ff96d468476c@alliedtelesis.co.nz>
Date: Thu, 20 Feb 2025 09:42:31 +1300
From: Chris Packham <chris.packham@...iedtelesis.co.nz>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: conor+dt@...nel.org, krzk+dt@...nel.org, linux-mips@...r.kernel.org,
 tsbogend@...ha.franken.de, andrew+netdev@...n.ch, pabeni@...hat.com,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 netdev@...r.kernel.org, kuba@...nel.org, edumazet@...gle.com,
 lee@...nel.org, davem@...emloft.net
Subject: Re: [RESEND PATCH net-next 3/5] dt-bindings: net: Add Realtek MDIO
 controller

Hi Rob,

On 20/02/2025 03:06, Rob Herring (Arm) wrote:
> On Wed, 19 Feb 2025 08:52:14 +1300, Chris Packham wrote:
>> Add dtschema for the MDIO controller found in the RTL9300 Ethernet
>> switch. The controller is slightly unusual in that direct MDIO
>> communication is not possible. We model the MDIO controller with the
>> MDIO buses as child nodes and the PHYs as children of the buses. The
>> mapping of switch port number to MDIO bus/addr requires the
>> ethernet-ports sibling to provide the mapping via the phy-handle
>> property.
>>
>> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
>> ---
>>
>> Notes:
>>      This is technically v7 of [1] and [2] which are combined now that
>>      rtl9301-switch.yaml under net/ the only change from those is that the
>>      $ref: in rtl9301-switch.yaml can now use a relative path
>>
>>      I could technically do away with the reg property on the mdio-controller
>>      node. I don't currently need to use it in my driver and it looks like
>>      the register offsets are the same between the RTL9300 and RTL9310.
>>
>>      [1] - https://lore.kernel.org/lkml/20250204030249.1965444-6-chris.packham@alliedtelesis.co.nz/
>>      [2] - https://lore.kernel.org/lkml/20250204030249.1965444-4-chris.packham@alliedtelesis.co.nz/
>>
>>   .../bindings/net/realtek,rtl9301-mdio.yaml    | 86 +++++++++++++++++++
>>   .../bindings/net/realtek,rtl9301-switch.yaml  | 31 +++++++
>>   2 files changed, 117 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/net/realtek,rtl9301-mdio.yaml
>>
>
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
>
> If a tag was not added on purpose, please state why and what changed.
>
> Missing tags:
>
> Reviewed-by: Rob Herring (Arm) <robh@...nel.org>

Sorry about that. I wasn't sure since this was spun off from the other 
series and because it now includes changes to 
realtek,rtl9301-switch.yaml. I should have at least mentioned that.

If there is another round for this one I'll include your r-by.