netdev - RE: [PATCH net-next 2/3] net: stmmac: remove useless priv->flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <OS7PR01MB148089F4C1A42FDCD46D5E3D192C52@OS7PR01MB14808.jpnprd01.prod.outlook.com>
Date: Wed, 19 Feb 2025 01:11:26 +0000
From: <nobuhiro1.iwamatsu@...hiba.co.jp>
To: <rmk+kernel@...linux.org.uk>, <netdev@...r.kernel.org>
CC: <alexandre.torgue@...s.st.com>, <andrew+netdev@...n.ch>, <wens@...e.org>,
        <davem@...emloft.net>, <drew@...7.com>, <kernel@...il.dk>,
        <edumazet@...gle.com>, <festevam@...il.com>, <wefu@...hat.com>,
        <guoren@...nel.org>, <imx@...ts.linux.dev>, <kuba@...nel.org>,
        <jan.petrous@....nxp.com>, <jernej.skrabec@...il.com>,
        <jbrunet@...libre.com>, <khilman@...libre.com>,
        <linux-amlogic@...ts.infradead.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-riscv@...ts.infradead.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-sunxi@...ts.linux.dev>, <martin.blumenstingl@...glemail.com>,
        <mcoquelin.stm32@...il.com>, <minda.chen@...rfivetech.com>,
        <neil.armstrong@...aro.org>, <s32@....com>, <pabeni@...hat.com>,
        <kernel@...gutronix.de>, <samuel@...lland.org>,
        <s.hauer@...gutronix.de>, <shawnguo@...nel.org>, <vkoul@...nel.org>
Subject: RE: [PATCH net-next 2/3] net: stmmac: remove useless priv->flow_ctrl

Hi Russell,

> -----Original Message-----
> From: Russell King <rmk@...linux.org.uk> On Behalf Of Russell King (Oracle)
> Sent: Tuesday, February 18, 2025 7:25 PM
> To: netdev@...r.kernel.org
> Cc: Alexandre Torgue <alexandre.torgue@...s.st.com>; Andrew Lunn
> <andrew+netdev@...n.ch>; Chen-Yu Tsai <wens@...e.org>; David S. Miller
> <davem@...emloft.net>; Drew Fustini <drew@...7.com>; Emil Renner
> Berthing <kernel@...il.dk>; Eric Dumazet <edumazet@...gle.com>; Fabio
> Estevam <festevam@...il.com>; Fu Wei <wefu@...hat.com>; Guo Ren
> <guoren@...nel.org>; imx@...ts.linux.dev; Jakub Kicinski
> <kuba@...nel.org>; Jan Petrous <jan.petrous@....nxp.com>; Jernej Skrabec
> <jernej.skrabec@...il.com>; Jerome Brunet <jbrunet@...libre.com>; Kevin
> Hilman <khilman@...libre.com>; linux-amlogic@...ts.infradead.org;
> linux-arm-kernel@...ts.infradead.org; linux-arm-msm@...r.kernel.org;
> linux-riscv@...ts.infradead.org; linux-stm32@...md-mailman.stormreply.com;
> linux-sunxi@...ts.linux.dev; Martin Blumenstingl
> <martin.blumenstingl@...glemail.com>; Maxime Coquelin
> <mcoquelin.stm32@...il.com>; Minda Chen
> <minda.chen@...rfivetech.com>; Neil Armstrong
> <neil.armstrong@...aro.org>; iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□Ｄ
> ＩＴ○ＯＳＴ) <nobuhiro1.iwamatsu@...hiba.co.jp>; NXP S32 Linux Team
> <s32@....com>; Paolo Abeni <pabeni@...hat.com>; Pengutronix Kernel
> Team <kernel@...gutronix.de>; Samuel Holland <samuel@...lland.org>;
> Sascha Hauer <s.hauer@...gutronix.de>; Shawn Guo
> <shawnguo@...nel.org>; Vinod Koul <vkoul@...nel.org>
> Subject: [PATCH net-next 2/3] net: stmmac: remove useless priv->flow_ctrl
> 
> priv->flow_ctrl is only accessed by stmmac_main.c, and the only place
> that it is read is in stmmac_mac_flow_ctrl(). This function is only called from
> stmmac_mac_link_up() which always sets priv->flow_ctrl immediately before
> calling this function.
> 
> Therefore, initialising this at probe time is ineffectual because it will always be
> overwritten before it's read. As such, the "flow_ctrl"
> module parameter has been useless for some time. Rather than remove the
> module parameter, which would risk module load failure, change the
> description to indicate that it is obsolete, and warn if it is set by userspace.
> 
> Moreover, storing the value in the stmmac_priv has no benefit as it's set and
> then immediately read stmmac_mac_flow_ctrl(). Instead, pass it as a
> parameter to this function..
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@...hiba.co.jp>

Best regards,
  Nobuhiro