netdev - Re: [PATCH iwl-next v2 0/4] igb: XDP/ZC follow up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250219180651.0ea6f33d@kernel.org>
Date: Wed, 19 Feb 2025 18:06:51 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Kurt Kanzenbach <kurt@...utronix.de>
Cc: Joe Damato <jdamato@...tly.com>, Tony Nguyen
 <anthony.l.nguyen@...el.com>, Przemek Kitszel
 <przemyslaw.kitszel@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, Sebastian Andrzej Siewior
 <bigeasy@...utronix.de>, Gerhard Engleder <gerhard@...leder-embedded.com>,
 intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org
Subject: Re: [PATCH iwl-next v2 0/4] igb: XDP/ZC follow up

On Wed, 19 Feb 2025 08:39:08 +0100 Kurt Kanzenbach wrote:
> > My comment from the previous series still stands, which simply that
> > I have no idea if the maintainers will accept changes using this API
> > or prefer to wait until Stanislav's work [1] is completed to remove
> > the RTNL requirement from this API altogether.  
> 
> I'd rather consider patch #2 a bugfix to restore the busy polling with
> XDP/ZC. After commit 5ef44b3cb43b ("xsk: Bring back busy polling
> support") it is a requirement to implement this API.
> 
> The maintainers didn't speak up on v1, so i went along and sent v2.
> 
> @Jakub: What's your preference? Would you accept this series or rather
> like to wait for Stanislav's work to be finished?

No strong preference. If rtnl_lock is not causing any issues 
in this driver, the we can merge as is. I haven't followed 
the past discussions, tho.