netdev - Re: [PATCH net 0/2] bond: fix xfrm offload feature during init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d1fe4ccfca946deae476d3bf18e4329068a54af4.camel@nvidia.com>
Date: Thu, 20 Feb 2025 11:33:34 +0000
From: Cosmin Ratiu <cratiu@...dia.com>
To: "liuhangbin@...il.com" <liuhangbin@...il.com>
CC: "shuah@...nel.org" <shuah@...nel.org>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, "davem@...emloft.net" <davem@...emloft.net>,
	"jv@...sburgh.net" <jv@...sburgh.net>, "sd@...asysnail.net"
	<sd@...asysnail.net>, "andy@...yhouse.net" <andy@...yhouse.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "pabeni@...hat.com"
	<pabeni@...hat.com>, "herbert@...dor.apana.org.au"
	<herbert@...dor.apana.org.au>, Jianbo Liu <jianbol@...dia.com>,
	"horms@...nel.org" <horms@...nel.org>, "kuba@...nel.org" <kuba@...nel.org>,
	Tariq Toukan <tariqt@...dia.com>, "razor@...ckwall.org"
	<razor@...ckwall.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"steffen.klassert@...unet.com" <steffen.klassert@...unet.com>,
	"linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH net 0/2] bond: fix xfrm offload feature during init

On Thu, 2025-02-20 at 11:18 +0000, Hangbin Liu wrote:
> 
> Thanks for the feedback and confirmation. Let me try it first. Hope
> unregistering bond doesn't affect the gc works.

I think this should be handled naturally as part of the bond device
tear down. A quick peek shows:
bond_uninit -> (for each slave) __bond_release_one ->
bond_change_active_slave (_, NULL) -> bond_ipsec_del_sa_all deletes all
matching xfrm_state entries from bond->ipsec_list, with the mutex held.

Presumably, a new step after all slaves are deleted should call
drain_workqueue on the new workqueue to wait for any scheduled work to
be done before finally destroying the workqueue.

Cosmin.