netdev - Re: [net-next PATCH v10 2/6] octeontx2-af: CN20k basic mbox operations and structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0f4651c-31a3-4831-89a4-ee3010b3b4ca@redhat.com>
Date: Thu, 20 Feb 2025 12:50:09 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Sai Krishna <saikrishnag@...vell.com>, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, sgoutham@...vell.com, gakula@...vell.com,
 lcherian@...vell.com, jerinj@...vell.com, hkelam@...vell.com,
 sbhatta@...vell.com, andrew+netdev@...n.ch,
 kalesh-anakkur.purayil@...adcom.com
Subject: Re: [net-next PATCH v10 2/6] octeontx2-af: CN20k basic mbox
 operations and structures

On 2/17/25 9:52 AM, Sai Krishna wrote:
> @@ -2443,6 +2469,18 @@ static int rvu_mbox_init(struct rvu *rvu, struct mbox_wq_info *mw,
>  		}
>  	}
>  
> +	ng_rvu_mbox = kzalloc(sizeof(*ng_rvu_mbox), GFP_KERNEL);
> +	if (!ng_rvu_mbox) {
> +		err = -ENOMEM;
> +		goto free_bitmap;
> +	}
> +
> +	rvu->ng_rvu = ng_rvu_mbox

AFAICS rvu->ng_rvu is freed only by rvu_remove(), so it's leaked on the
later error paths.

/P