netdev - RE: [PATCH net-next 2/2] net: axienet: Add support for AXI 2.5G MAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <BL3PR12MB6571DD63F0AEE29BF2CDFC00C9C42@BL3PR12MB6571.namprd12.prod.outlook.com>
Date: Thu, 20 Feb 2025 12:17:19 +0000
From: "Gupta, Suraj" <Suraj.Gupta2@....com>
To: Russell King <linux@...linux.org.uk>
CC: Sean Anderson <sean.anderson@...ux.dev>, Andrew Lunn <andrew@...n.ch>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"Simek, Michal" <michal.simek@....com>, "Pandey, Radhey Shyam"
	<radhey.shyam.pandey@....com>, "horms@...nel.org" <horms@...nel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "git (AMD-Xilinx)" <git@....com>, "Katakam,
 Harini" <harini.katakam@....com>
Subject: RE: [PATCH net-next 2/2] net: axienet: Add support for AXI 2.5G MAC

[AMD Official Use Only - AMD Internal Distribution Only]

> -----Original Message-----
> From: Russell King <linux@...linux.org.uk>
> Sent: Thursday, February 20, 2025 5:14 PM
> To: Gupta, Suraj <Suraj.Gupta2@....com>
> Cc: Sean Anderson <sean.anderson@...ux.dev>; Andrew Lunn <andrew@...n.ch>;
> andrew+netdev@...n.ch; davem@...emloft.net; edumazet@...gle.com;
> kuba@...nel.org; pabeni@...hat.com; Simek, Michal <michal.simek@....com>;
> Pandey, Radhey Shyam <radhey.shyam.pandey@....com>; horms@...nel.org;
> netdev@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> kernel@...r.kernel.org; git (AMD-Xilinx) <git@....com>; Katakam, Harini
> <harini.katakam@....com>
> Subject: Re: [PATCH net-next 2/2] net: axienet: Add support for AXI 2.5G MAC
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> On Thu, Feb 20, 2025 at 11:30:52AM +0000, Gupta, Suraj wrote:
> > Sorry for picking up this thread after long time, we checked
> > internally with AMD IP and hardware experts and it is true that you
> > can use this MAC and PCS to operate at 1G and 2.5G both. It is also
> > possible to switch between these two speeds dynamically using external
> > GT and/or if an external RTL logic is implemented in the FPGA. That
> > will include some GPIO or register based selections to change the
> > clock and configurations to switch between the speeds.
> > Our current solution does not support this and is meant for a static
> > speed selection only.
>
> Thanks for getting back on this.
>
> Okay, so it's a synthesis option, where that may be one of:
>
> 1. SGMII/1000base-X only
> 2. 2500base-X only
> 3. dynamically switching between (1) and (2).
>
> > We'll use MAC ability register to detect if MAC is configured for
> > 2.5G. Will it be fine to advertise both 1G and 2.5G in that case?
>
> Please document in a comment that the above are synthesis options, and that
> dynamically changing between them is possible but not implemented by the driver.
> Note that should anyone use axienet for SFP modules, then (1) is essentially the
> base functionality, (2) is very limiting, and (3) would be best.
>
> Not only will one want to limit the MAC capabilities, but also the supported interface
> modes. As it's been so long since the patch was posted, I don't remember whether it
> did that or not.
>

Sure, will document in the comment and limit both mac capabilities and supported interfaces accordingly.
Thank you for your quick response and guidance. I really appreciate your support!

> Thanks.
>
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!