netdev - Re: [PATCH net-next v3 2/2] net: plumb extack in __dev_change_net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <101c5d62-d1e9-4ac4-a254-5aeafeac6033@6wind.com>
Date: Thu, 20 Feb 2025 14:22:15 +0100
From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Alexander Lobakin <aleksander.lobakin@...el.com>,
 Ido Schimmel <idosch@...sch.org>, Andrew Lunn <andrew@...n.ch>,
 netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3 2/2] net: plumb extack in
 __dev_change_net_namespace()

Le 20/02/2025 à 14:17, Eric Dumazet a écrit :
> On Thu, Feb 20, 2025 at 2:03 PM Nicolas Dichtel
> <nicolas.dichtel@...nd.com> wrote:
>>
>> It could be hard to understand why the netlink command fails. For example,
>> if dev->netns_local is set, the error is "Invalid argument".
>>
> 
> After your patch, a new message is : "  "The interface has the 'netns
> local' property""
> 
> Honestly, I am not sure we export to user space the concept of 'netns local'
> 
> "This interface netns is not allowed to be changed" or something like that ?
Frankly, I was hesitating. I used 'netns local' to ease the link with the new
netlink attribute, and with what was displayed by ethtool for a long time.
I don't have a strong opinion about this.