netdev - Re: [PATCH net-next] net: cadence: macb: Implement BQL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0d729331-fab0-4b59-8d58-ce22e99b269a@linux.dev>
Date: Thu, 20 Feb 2025 11:53:23 -0500
From: Sean Anderson <sean.anderson@...ux.dev>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Nicolas Ferre <nicolas.ferre@...rochip.com>,
 Claudiu Beznea <claudiu.beznea@...on.dev>, netdev@...r.kernel.org,
 "David S . Miller" <davem@...emloft.net>, Andrew Lunn
 <andrew+netdev@...n.ch>, linux-kernel@...r.kernel.org,
 Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next] net: cadence: macb: Implement BQL

On 2/20/25 11:51, Jakub Kicinski wrote:
> On Thu, 20 Feb 2025 10:55:45 -0500 Sean Anderson wrote:
>> On 2/18/25 20:57, Jakub Kicinski wrote:
>> > On Fri, 14 Feb 2025 16:16:43 -0500 Sean Anderson wrote:  
>> >> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
>> >> index 48496209fb16..63c65b4bb348 100644
>> >> --- a/drivers/net/ethernet/cadence/macb_main.c
>> >> +++ b/drivers/net/ethernet/cadence/macb_main.c
>> >> @@ -1081,6 +1081,9 @@ static void macb_tx_error_task(struct work_struct *work)
>> >>  						      tx_error_task);
>> >>  	bool			halt_timeout = false;
>> >>  	struct macb		*bp = queue->bp;
>> >> +	u32			queue_index = queue - bp->queues;  
>> > 
>> > nit: breaking reverse xmas tree here  
>> 
>> It has to happen here since bp isn't available earlier.
> 
> Move it from init to normal code?

That's what I ended up doing.

--Sean