netdev - Re: [PATCH net-next v2 3/7] selftests: drv-net: add missing new line in xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z7drCEsGAQz6cxjf@LQ3V64L9R2>
Date: Thu, 20 Feb 2025 12:48:56 -0500
From: Joe Damato <jdamato@...tly.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
	stfomichev@...il.com, petrm@...dia.com
Subject: Re: [PATCH net-next v2 3/7] selftests: drv-net: add missing new line
 in xdp_helper

On Wed, Feb 19, 2025 at 03:49:52PM -0800, Jakub Kicinski wrote:
> Kurt and Joe report missing new line at the end of Usage.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> v2: new
> ---
>  tools/testing/selftests/drivers/net/xdp_helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/drivers/net/xdp_helper.c b/tools/testing/selftests/drivers/net/xdp_helper.c
> index cf06a88b830b..80f86c2fe1a5 100644
> --- a/tools/testing/selftests/drivers/net/xdp_helper.c
> +++ b/tools/testing/selftests/drivers/net/xdp_helper.c
> @@ -35,7 +35,7 @@ int main(int argc, char **argv)
>  	char byte;
>  
>  	if (argc != 3) {
> -		fprintf(stderr, "Usage: %s ifindex queue_id", argv[0]);
> +		fprintf(stderr, "Usage: %s ifindex queue_id\n", argv[0]);
>  		return 1;
>  	}

Reviewed-by: Joe Damato <jdamato@...tly.com>