netdev - Re: [PATCH net-next v2 0/7] selftests: drv-net: improve the queue test for XSK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z7eD866CFu_KeWOw@LQ3V64L9R2>
Date: Thu, 20 Feb 2025 14:35:15 -0500
From: Joe Damato <jdamato@...tly.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
	stfomichev@...il.com, petrm@...dia.com
Subject: Re: [PATCH net-next v2 0/7] selftests: drv-net: improve the queue
 test for XSK

On Wed, Feb 19, 2025 at 03:49:49PM -0800, Jakub Kicinski wrote:
> We see some flakes in the the XSK test:
> 
>    Exception| Traceback (most recent call last):
>    Exception|   File "/home/virtme/testing-18/tools/testing/selftests/net/lib/py/ksft.py", line 218, in ksft_run
>    Exception|     case(*args)
>    Exception|   File "/home/virtme/testing-18/tools/testing/selftests/drivers/net/./queues.py", line 53, in check_xdp
>    Exception|     ksft_eq(q['xsk'], {})
>    Exception| KeyError: 'xsk'
> 
> I think it's because the method or running the helper in the background
> is racy. Add more solid infra for waiting for a background helper to be
> initialized.
> 
> v2:
>  - add patch 1, 3 and 4
>  - redo patch 5
> v1: https://lore.kernel.org/20250218195048.74692-1-kuba@kernel.org

Thanks for doing this work.

I tested this on my system in four cases:
  - XDP disabled:
    - NETIF=mlx5
    - NETIF unset
  - XDP enabled
    - NETIF=mlx5
    - NETIF unset

The warning in patch 1 does not print on my system, but the code
changes introduced in patch 5/7 fix the hang.

I've already given my Reviewed-by / Acked-by on all patches, so not
sure if it matters but since I did test this as described above:

Tested-by: Joe Damato <jdamato@...tly.com>