netdev - Re: [PATCH bpf-next v13 00/12] net-timestamp: bpf extension to equip applications transparently

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL+tcoCK1H0-gV4Vi0=gCmq8QoDLtihFijbsspODcprh3Dbo3w@mail.gmail.com>
Date: Fri, 21 Feb 2025 07:17:26 +0800
From: Jason Xing <kerneljasonxing@...il.com>
To: Martin KaFai Lau <martin.lau@...ux.dev>
Cc: Willem de Bruijn <willemdebruijn.kernel@...il.com>, davem@...emloft.net, 
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, dsahern@...nel.org, 
	willemb@...gle.com, ast@...nel.org, daniel@...earbox.net, andrii@...nel.org, 
	eddyz87@...il.com, song@...nel.org, yonghong.song@...ux.dev, 
	john.fastabend@...il.com, kpsingh@...nel.org, sdf@...ichev.me, 
	haoluo@...gle.com, jolsa@...nel.org, shuah@...nel.org, ykolal@...com, 
	bpf@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next v13 00/12] net-timestamp: bpf extension to equip
 applications transparently

On Fri, Feb 21, 2025 at 7:02 AM Martin KaFai Lau <martin.lau@...ux.dev> wrote:
>
> On 2/20/25 7:32 AM, Willem de Bruijn wrote:
> > Jason Xing wrote:
> >> "Timestamping is key to debugging network stack latency. With
> >> SO_TIMESTAMPING, bugs that are otherwise incorrectly assumed to be
> >> network issues can be attributed to the kernel." This is extracted
> >> from the talk "SO_TIMESTAMPING: Powering Fleetwide RPC Monitoring"
> >> addressed by Willem de Bruijn at netdevconf 0x17).
> >>
> >> There are a few areas that need optimization with the consideration of
> >> easier use and less performance impact, which I highlighted and mainly
> >> discussed at netconf 2024 with Willem de Bruijn and John Fastabend:
> >> uAPI compatibility, extra system call overhead, and the need for
> >> application modification. I initially managed to solve these issues
> >> by writing a kernel module that hooks various key functions. However,
> >> this approach is not suitable for the next kernel release. Therefore,
> >> a BPF extension was proposed. During recent period, Martin KaFai Lau
> >> provides invaluable suggestions about BPF along the way. Many thanks
> >> here!
> >>
> >> This series adds the BPF networking timestamping infrastructure through
> >> reusing most of the tx timestamping callback that is currently enabled
> >> by the SO_TIMESTAMPING.. This series also adds TX timestamping support
> >> for TCP. The RX timestamping and UDP support will be added in the future.
>
> Thanks for working on this BPF feature. Applied.

Thanks Martin for sharing invaluable and precious knowledge on BPF design !!!
Thanks Willem for great effort on suggesting from the insightful
perspective of the networking area !!!

>
> > This series addresses all my feedback.
> >
> > The timestamping patches all have my Reviewed-by.
>
> Thanks to Willem and other reviewers for their input in this long thread across
> many revisions.

Thanks everyone from the bottom of my heart :)

Thanks,
Jason