netdev - Re: [PATCH net-next v9 07/10] bnxt_en: add support for tcp-data-split ethtool command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250219170737.25a3a4ed@kernel.org>
Date: Wed, 19 Feb 2025 17:07:37 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Daniel Xu <dxu@...uu.xyz>
Cc: Taehee Yoo <ap420073@...il.com>, davem@...emloft.net, pabeni@...hat.com,
 edumazet@...gle.com, netdev@...r.kernel.org, almasrymina@...gle.com,
 donald.hunter@...il.com, corbet@....net, michael.chan@...adcom.com,
 andrew+netdev@...n.ch, hawk@...nel.org, ilias.apalodimas@...aro.org,
 ast@...nel.org, daniel@...earbox.net, john.fastabend@...il.com,
 dw@...idwei.uk, sdf@...ichev.me, asml.silence@...il.com,
 brett.creeley@....com, linux-doc@...r.kernel.org,
 kory.maincent@...tlin.com, maxime.chevallier@...tlin.com,
 danieller@...dia.com, hengqi@...ux.alibaba.com, ecree.xilinx@...il.com,
 przemyslaw.kitszel@...el.com, hkallweit1@...il.com, ahmed.zaki@...el.com,
 rrameshbabu@...dia.com, idosch@...dia.com, jiri@...nulli.us,
 bigeasy@...utronix.de, lorenzo@...nel.org, jdamato@...tly.com,
 aleksander.lobakin@...el.com, kaiyuanz@...gle.com, willemb@...gle.com,
 daniel.zahka@...il.com, Andy Gospodarek <gospo@...adcom.com>
Subject: Re: [PATCH net-next v9 07/10] bnxt_en: add support for
 tcp-data-split ethtool command

On Wed, 19 Feb 2025 10:11:01 -0700 Daniel Xu wrote:
> > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c
> > index f88b641533fc..1bfff7f29310 100644
> > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c
> > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c
> > @@ -395,6 +395,10 @@ static int bnxt_xdp_set(struct bnxt *bp, struct bpf_prog *prog)
> >  			    bp->dev->mtu, BNXT_MAX_PAGE_MODE_MTU);
> >  		return -EOPNOTSUPP;
> >  	}
> > +	if (prog && bp->flags & BNXT_FLAG_HDS) {
> > +		netdev_warn(dev, "XDP is disallowed when HDS is enabled.\n");
> > +		return -EOPNOTSUPP;
> > +	}  
> 
> I think there might be a bug here. On my 6.13 (ish) kernel when I try to
> install an XDP driver mode program, I get:
> 
>     [Tue Feb 18 17:02:14 2025] bnxt_en 0000:01:00.0 eth0: XDP is disallowed when HDS is enabled.
> 
> Setting HDS to auto (seems like off isn't supported?) doesn't seem to
> help either:

This should fix it, I think:

https://lore.kernel.org/20250220005318.560733-1-kuba@kernel.org